fpdfsdk/fpdfformfill_embeddertest.cpp - Issue 2258333002: Fix page leaks in an embedder test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/fpdfformfill_embeddertest.cpp

Issue 2258333002: Fix page leaks in an embedder test (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: new approach Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/fpdfformfill_embeddertest.cpp

diff --git a/fpdfsdk/fpdfformfill_embeddertest.cpp b/fpdfsdk/fpdfformfill_embeddertest.cpp

index 3a6a7448e5a4c49415ff6f6412fea8babd2bc6d2..baf4853f173d746be8635af713be4a5ef560f1ce 100644

--- a/fpdfsdk/fpdfformfill_embeddertest.cpp

+++ b/fpdfsdk/fpdfformfill_embeddertest.cpp

@@ -45,7 +45,7 @@ TEST_F(FPDFFormFillEmbeddertest, BUG_507316) {

SetDelegate(&delegate);

EXPECT_TRUE(OpenDocument("bug_507316.pdf"));

- FPDF_PAGE page = LoadAndCachePage(2);

+ FPDF_PAGE page = LoadPage(2);

EXPECT_TRUE(page);

DoOpenActions();

delegate.AdvanceTime(4000);

« no previous file with comments | « no previous file | fpdfsdk/fsdk_baseform_embeddertest.cpp » ('j') | no next file with comments »