Fix page leaks in an embedder test

fpdfsdk/fsdk_mgr.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "fpdfsdk/include/fsdk_mgr.h"
 
 #include <algorithm>
 #include <memory>
@@ skipping 281 matching lines @@
   return pPage ? GetPageView(pPage, true) : nullptr;
 }
 
 CPDFSDK_PageView* CPDFSDK_Document::GetPageView(int nIndex) {
   UnderlyingPageType* pTempPage =
       UnderlyingFromFPDFPage(m_pEnv->FFI_GetPage(m_pDoc, nIndex));
   if (!pTempPage)
     return nullptr;
 
   auto it = m_pageMap.find(pTempPage);
-  return it->second;
+#ifdef PDF_ENABLE_XFA
+  pTempPage->Release();

[Tom Sepez, 2016/08/22 19:42:51]

might this cause the page to be removed from the map, invalidating it?  Do pages
clean themselves up when destroyed?

+#endif
+  return it == m_pageMap.end() ? nullptr : it->second;
 }
 
 void CPDFSDK_Document::ProcJavascriptFun() {
   CPDF_Document* pPDFDoc = GetPDFDocument();
   CPDF_DocJSActions docJS(pPDFDoc);
   int iCount = docJS.CountJSActions();
   if (iCount < 1)
     return;
   for (int i = 0; i < iCount; i++) {
     CFX_ByteString csJSName;
@@ skipping 744 matching lines @@
 int CPDFSDK_PageView::GetPageIndexForStaticPDF() const {
 #ifdef PDF_ENABLE_XFA
   CPDF_Page* pPage = m_page->GetPDFPage();
 #else   // PDF_ENABLE_XFA
   CPDF_Page* pPage = m_page;
 #endif  // PDF_ENABLE_XFA
   CPDF_Dictionary* pDict = pPage->m_pFormDict;
   CPDF_Document* pDoc = m_pSDKDoc->GetPDFDocument();
   return (pDoc && pDict) ? pDoc->GetPageIndex(pDict->GetObjNum()) : -1;
 }