third_party/WebKit/Source/core/html/HTMLOptionsCollection.cpp - Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLOptionsCollection.cpp

Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLOptionElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLOptionsCollection.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLOptionsCollection.cpp b/third_party/WebKit/Source/core/html/HTMLOptionsCollection.cpp

index a48e5e5c1961e1082da369e91fe54262a7a8d7cf..24fa19d25e1985791c3de00c5adef6244c5c2155 100644

--- a/third_party/WebKit/Source/core/html/HTMLOptionsCollection.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLOptionsCollection.cpp

@@ -35,7 +35,7 @@ namespace blink {

HTMLOptionsCollection::HTMLOptionsCollection(ContainerNode& select)

: HTMLCollection(select, SelectOptions, DoesNotOverrideItemAfter)

{

- ASSERT(isHTMLSelectElement(select));

+ DCHECK(isHTMLSelectElement(select));

}

void HTMLOptionsCollection::supportedPropertyNames(Vector<String>& names)

@@ -48,7 +48,7 @@ void HTMLOptionsCollection::supportedPropertyNames(Vector<String>& names)

unsigned length = this->length();

for (unsigned i = 0; i < length; ++i) {

Element* element = item(i);

- ASSERT(element);

+ DCHECK(element);

const AtomicString& idAttribute = element->getIdAttribute();

if (!idAttribute.isEmpty()) {

HashSet<AtomicString>::AddResult addResult = existingNames.add(idAttribute);