third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp - Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLOptionsCollection.cpp ('k') | third_party/WebKit/Source/core/html/HTMLProgressElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp b/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

index f7c210bd331f98a0d5238fdde3d2c8085aac7207..9560644cd4e5f23b93d9c5c83aa72bb22beffedc 100644

--- a/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

@@ -84,7 +84,7 @@ HTMLPlugInElement::HTMLPlugInElement(const QualifiedName& tagName, Document& doc

HTMLPlugInElement::~HTMLPlugInElement()

{

DCHECK(!m_pluginWrapper); // cleared in detachLayoutTree()

- ASSERT(!m_isDelayingLoadEvent);

+ DCHECK(!m_isDelayingLoadEvent);

}

DEFINE_TRACE(HTMLPlugInElement)

@@ -103,7 +103,7 @@ void HTMLPlugInElement::setPersistedPluginWidget(Widget* widget)

m_persistedPluginWidget->hide();

disposeWidgetSoon(m_persistedPluginWidget.release());

} else {

- ASSERT(m_persistedPluginWidget->isFrameView() || m_persistedPluginWidget->isRemoteFrameView());

+ DCHECK(m_persistedPluginWidget->isFrameView() || m_persistedPluginWidget->isRemoteFrameView());

}

m_persistedPluginWidget = widget;

@@ -234,7 +234,7 @@ void HTMLPlugInElement::requestPluginCreationWithoutLayoutObjectIfPossible()

void HTMLPlugInElement::createPluginWithoutLayoutObject()

{

- ASSERT(document().frame()->loader().client()->canCreatePluginWithoutRenderer(m_serviceType));

+ DCHECK(document().frame()->loader().client()->canCreatePluginWithoutRenderer(m_serviceType));

KURL url;

// CSP can block src-less objects.

@@ -474,7 +474,7 @@ bool HTMLPlugInElement::allowedToLoadFrameURL(const String& url)

// that <object> uses depending on <param> values.

bool HTMLPlugInElement::wouldLoadAsNetscapePlugin(const String& url, const String& serviceType)

{

- ASSERT(document().frame());

+ DCHECK(document().frame());

KURL completedURL;

if (!url.isEmpty())

completedURL = document().completeURL(url);