Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLOptionsCollection.cpp

Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2011, 2012 Apple Computer, Inc. 2 * Copyright (C) 2006, 2011, 2012 Apple Computer, Inc.
3 * Copyright (C) 2014 Samsung Electronics. All rights reserved. 3 * Copyright (C) 2014 Samsung Electronics. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 17 matching lines...) Expand all
28 #include "bindings/core/v8/NodeListOrElement.h" 28 #include "bindings/core/v8/NodeListOrElement.h"
29 #include "core/dom/StaticNodeList.h" 29 #include "core/dom/StaticNodeList.h"
30 #include "core/html/HTMLOptionElement.h" 30 #include "core/html/HTMLOptionElement.h"
31 #include "core/html/HTMLSelectElement.h" 31 #include "core/html/HTMLSelectElement.h"
32 32
33 namespace blink { 33 namespace blink {
34 34
35 HTMLOptionsCollection::HTMLOptionsCollection(ContainerNode& select) 35 HTMLOptionsCollection::HTMLOptionsCollection(ContainerNode& select)
36 : HTMLCollection(select, SelectOptions, DoesNotOverrideItemAfter) 36 : HTMLCollection(select, SelectOptions, DoesNotOverrideItemAfter)
37 { 37 {
38 ASSERT(isHTMLSelectElement(select)); 38 DCHECK(isHTMLSelectElement(select));
39 } 39 }
40 40
41 void HTMLOptionsCollection::supportedPropertyNames(Vector<String>& names) 41 void HTMLOptionsCollection::supportedPropertyNames(Vector<String>& names)
42 { 42 {
43 // As per http://www.whatwg.org/specs/web-apps/current-work/multipage/common -dom-interfaces.html#htmloptionscollection: 43 // As per http://www.whatwg.org/specs/web-apps/current-work/multipage/common -dom-interfaces.html#htmloptionscollection:
44 // The supported property names consist of the non-empty values of all the i d and name attributes of all the elements 44 // The supported property names consist of the non-empty values of all the i d and name attributes of all the elements
45 // represented by the collection, in tree order, ignoring later duplicates, with the id of an element preceding its 45 // represented by the collection, in tree order, ignoring later duplicates, with the id of an element preceding its
46 // name if it contributes both, they differ from each other, and neither is the duplicate of an earlier entry. 46 // name if it contributes both, they differ from each other, and neither is the duplicate of an earlier entry.
47 HashSet<AtomicString> existingNames; 47 HashSet<AtomicString> existingNames;
48 unsigned length = this->length(); 48 unsigned length = this->length();
49 for (unsigned i = 0; i < length; ++i) { 49 for (unsigned i = 0; i < length; ++i) {
50 Element* element = item(i); 50 Element* element = item(i);
51 ASSERT(element); 51 DCHECK(element);
52 const AtomicString& idAttribute = element->getIdAttribute(); 52 const AtomicString& idAttribute = element->getIdAttribute();
53 if (!idAttribute.isEmpty()) { 53 if (!idAttribute.isEmpty()) {
54 HashSet<AtomicString>::AddResult addResult = existingNames.add(idAtt ribute); 54 HashSet<AtomicString>::AddResult addResult = existingNames.add(idAtt ribute);
55 if (addResult.isNewEntry) 55 if (addResult.isNewEntry)
56 names.append(idAttribute); 56 names.append(idAttribute);
57 } 57 }
58 const AtomicString& nameAttribute = element->getNameAttribute(); 58 const AtomicString& nameAttribute = element->getNameAttribute();
59 if (!nameAttribute.isEmpty()) { 59 if (!nameAttribute.isEmpty()) {
60 HashSet<AtomicString>::AddResult addResult = existingNames.add(nameA ttribute); 60 HashSet<AtomicString>::AddResult addResult = existingNames.add(nameA ttribute);
61 if (addResult.isNewEntry) 61 if (addResult.isNewEntry)
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 HTMLSelectElement& base = toHTMLSelectElement(ownerNode()); 116 HTMLSelectElement& base = toHTMLSelectElement(ownerNode());
117 if (!value) { // undefined or null 117 if (!value) { // undefined or null
118 base.remove(index); 118 base.remove(index);
119 return true; 119 return true;
120 } 120 }
121 base.setOption(index, value, exceptionState); 121 base.setOption(index, value, exceptionState);
122 return true; 122 return true;
123 } 123 }
124 124
125 } // namespace blink 125 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLOptionElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698