Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 225783003: Remove ScriptState from NodeIterator, NodeFilter, NodeFilterCondition and TreeWalker (Closed)

Created:
6 years, 8 months ago by haraken
Modified:
6 years, 8 months ago
CC:
blink-reviews, Nils Barth (inactive), rwlbuis, kojih, arv+blink, jsbell+bindings_chromium.org, eae+blinkwatch, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Remove ScriptState from NodeIterator, NodeFilter, NodeFilterCondition and TreeWalker I'm deprecating ScriptState. This CL removes ScriptState from NodeIterator, NodeFilter, NodeFilterCondition and TreeWalker. What they really need is just ExceptionState, so this CL replaces ScriptState with ExceptionState. BUG=357144 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170871

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -85 lines) Patch
M Source/bindings/v8/V8NodeFilterCondition.h View 1 4 chunks +4 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8NodeFilterCondition.cpp View 1 4 chunks +10 lines, -10 lines 0 comments Download
M Source/core/dom/NodeFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NodeFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/NodeFilter.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NodeFilterCondition.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/dom/NodeFilterCondition.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NodeIterator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/NodeIterator.cpp View 5 chunks +6 lines, -7 lines 0 comments Download
M Source/core/dom/NodeIterator.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/NodeIteratorBase.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/NodeIteratorBase.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/dom/TreeWalker.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/dom/TreeWalker.cpp View 10 chunks +31 lines, -32 lines 0 comments Download
M Source/core/dom/TreeWalker.idl View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
haraken
PTAL
6 years, 8 months ago (2014-04-04 12:12:04 UTC) #1
dcarney
lgtm, nit https://codereview.chromium.org/225783003/diff/1/Source/bindings/v8/V8NodeFilterCondition.cpp File Source/bindings/v8/V8NodeFilterCondition.cpp (right): https://codereview.chromium.org/225783003/diff/1/Source/bindings/v8/V8NodeFilterCondition.cpp#newcode56 Source/bindings/v8/V8NodeFilterCondition.cpp:56: v8::Isolate* isolate = v8::Isolate::GetCurrent(); please cache isolate ...
6 years, 8 months ago (2014-04-04 12:14:42 UTC) #2
haraken
Thanks for the quick review! https://codereview.chromium.org/225783003/diff/1/Source/bindings/v8/V8NodeFilterCondition.cpp File Source/bindings/v8/V8NodeFilterCondition.cpp (right): https://codereview.chromium.org/225783003/diff/1/Source/bindings/v8/V8NodeFilterCondition.cpp#newcode56 Source/bindings/v8/V8NodeFilterCondition.cpp:56: v8::Isolate* isolate = v8::Isolate::GetCurrent(); ...
6 years, 8 months ago (2014-04-04 12:21:37 UTC) #3
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 8 months ago (2014-04-04 12:21:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/225783003/20001
6 years, 8 months ago (2014-04-04 12:21:54 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-04 12:52:52 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 8 months ago (2014-04-04 12:52:52 UTC) #7
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 8 months ago (2014-04-04 13:42:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/225783003/20001
6 years, 8 months ago (2014-04-04 13:42:41 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-04 14:05:35 UTC) #10
Message was sent while issue was closed. 
Change committed as 170871

Powered by Google App Engine
This is Rietveld 408576698