[Remoting Android] Remove old renderer code

[Remoting Android] Remove old renderer code

We started using OpenGL to render the host on the android client and the code
for the old renderer becomes obsolete. This CL removes code for the old
renderer so that we don't have burden to maintain unused code.

BUG=638305
Committed: https://crrev.com/6e1a8ab14a0babc5600a6d3d6f2557557de3ac70
Cr-Commit-Position: refs/heads/master@{#412716}

[Yuwei, 2016-08-17 23:39:28]

The CQ bit was checked by yuweih@chromium.org to run a CQ dry run

[Yuwei, 2016-08-17 23:39:53]

yuweih@chromium.org changed reviewers:
+ joedow@chromium.org, lambroslambrou@chromium.org

[Yuwei, 2016-08-17 23:39:53]

ptal

[commit-bot: I haz the power, 2016-08-17 23:40:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joedow, 2016-08-18 00:06:44]

lgtm

https://codereview.chromium.org/2256943002/diff/1/remoting/android/BUILD.gn
File remoting/android/BUILD.gn (right):

https://codereview.chromium.org/2256943002/diff/1/remoting/android/BUILD.gn#n...
remoting/android/BUILD.gn:16:
"java/src/org/chromium/chromoting/jni/GlDisplay.java",
You may consider renaming the *Gl* files once this removal is done.  You don't
need to specify that something is using OpenGl in the name since there will only
be one :)

[Yuwei, 2016-08-18 00:08:10]

On 2016/08/18 00:06:44, joedow wrote:
> lgtm

Thanks!

> https://codereview.chromium.org/2256943002/diff/1/remoting/android/BUILD.gn
> File remoting/android/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2256943002/diff/1/remoting/android/BUILD.gn#n...
> remoting/android/BUILD.gn:16:
> "java/src/org/chromium/chromoting/jni/GlDisplay.java",
> You may consider renaming the *Gl* files once this removal is done.  You don't
> need to specify that something is using OpenGl in the name since there will
only
> be one :)

Acknowledged.

[Lambros, 2016-08-18 00:32:08]

lgtm

[commit-bot: I haz the power, 2016-08-18 01:11:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 01:11:56]

Dry run: This issue passed the CQ dry run.

[Yuwei, 2016-08-18 01:13:01]

The CQ bit was checked by yuweih@chromium.org

[commit-bot: I haz the power, 2016-08-18 01:13:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 01:20:16]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-18 01:21:58]

Description was changed from

==========
[Remoting Android] Remove old renderer code

We started using OpenGL to render the host on the android client and the code
for the old renderer becomes obsolete. This CL removes code for the old
renderer so that we don't have burden to maintain unused code.

BUG=638305
==========

to

==========
[Remoting Android] Remove old renderer code

We started using OpenGL to render the host on the android client and the code
for the old renderer becomes obsolete. This CL removes code for the old
renderer so that we don't have burden to maintain unused code.

BUG=638305

Committed: https://crrev.com/6e1a8ab14a0babc5600a6d3d6f2557557de3ac70
Cr-Commit-Position: refs/heads/master@{#412716}
==========

[commit-bot: I haz the power, 2016-08-18 01:21:59]

Patchset 1 (id:??) landed as
https://crrev.com/6e1a8ab14a0babc5600a6d3d6f2557557de3ac70
Cr-Commit-Position: refs/heads/master@{#412716}

[Sergey Ulanov, 2016-08-18 06:14:19]

sergeyu@chromium.org changed reviewers:
+ sergeyu@chromium.org

[Sergey Ulanov, 2016-08-18 06:14:20]

https://codereview.chromium.org/2256943002/diff/1/remoting/android/java/src/o...
File remoting/android/java/src/org/chromium/chromoting/TouchInputStrategy.java
(right):

https://codereview.chromium.org/2256943002/diff/1/remoting/android/java/src/o...
remoting/android/java/src/org/chromium/chromoting/TouchInputStrategy.java:177:
public AbstractDesktopView.InputFeedbackType getShortPressFeedbackType() {
Maybe rename AbstractDesktopView->DesktopView, now that we don't have
DesktopView?

[Yuwei, 2016-08-18 06:49:16]

On 2016/08/18 06:14:20, Sergey Ulanov wrote:
>
https://codereview.chromium.org/2256943002/diff/1/remoting/android/java/src/o...
> File remoting/android/java/src/org/chromium/chromoting/TouchInputStrategy.java
> (right):
> 
>
https://codereview.chromium.org/2256943002/diff/1/remoting/android/java/src/o...
> remoting/android/java/src/org/chromium/chromoting/TouchInputStrategy.java:177:
> public AbstractDesktopView.InputFeedbackType getShortPressFeedbackType() {
> Maybe rename AbstractDesktopView->DesktopView, now that we don't have
> DesktopView?

Actually Joe suggested that we can rename the GlDesktopView to DesktopView, but
now I'm more inclined to your suggestion and keep GlDesktopView as it is. If the
VR thing revives in the future then we may have VrDesktopView :)