Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: remoting/client/jni/jni_video_renderer.cc

Issue 2256943002: [Remoting Android] Remove old renderer code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "remoting/client/jni/jni_video_renderer.h"
6
7 #include <stdint.h>
8
9 #include "base/android/jni_android.h"
10 #include "base/android/scoped_java_ref.h"
11 #include "base/logging.h"
12 #include "base/memory/ptr_util.h"
13 #include "remoting/base/util.h"
14 #include "remoting/client/jni/chromoting_jni_instance.h"
15 #include "remoting/client/jni/chromoting_jni_runtime.h"
16 #include "remoting/client/jni/jni_client.h"
17 #include "remoting/client/jni/jni_display_handler.h"
18 #include "third_party/webrtc/modules/desktop_capture/desktop_frame.h"
19 #include "third_party/webrtc/modules/desktop_capture/desktop_region.h"
20 #include "ui/gfx/android/java_bitmap.h"
21
22 namespace remoting {
23
24 class JniVideoRenderer::Renderer {
25 public:
26 Renderer(ChromotingJniRuntime* jni_runtime,
27 base::WeakPtr<JniDisplayHandler> display)
28 : jni_runtime_(jni_runtime), display_handler_(display) {}
29 ~Renderer() {
30 DCHECK(jni_runtime_->display_task_runner()->BelongsToCurrentThread());
31 }
32
33 void RenderFrame(std::unique_ptr<webrtc::DesktopFrame> frame);
34
35 private:
36 // Used to obtain task runner references and make calls to Java methods.
37 ChromotingJniRuntime* jni_runtime_;
38
39 base::WeakPtr<JniDisplayHandler> display_handler_;
40
41 // This global reference is required, instead of a local reference, so it
42 // remains valid for the lifetime of |bitmap_| - gfx::JavaBitmap does not
43 // create its own global reference internally. And this global ref must be
44 // destroyed (released) after |bitmap_| is destroyed.
45 base::android::ScopedJavaGlobalRef<jobject> bitmap_global_ref_;
46
47 // Reference to the frame bitmap that is passed to Java when the frame is
48 // allocated. This provides easy access to the underlying pixels.
49 std::unique_ptr<gfx::JavaBitmap> bitmap_;
50 };
51
52 // Function called on the display thread to render the frame.
53 void JniVideoRenderer::Renderer::RenderFrame(
54 std::unique_ptr<webrtc::DesktopFrame> frame) {
55 DCHECK(jni_runtime_->display_task_runner()->BelongsToCurrentThread());
56 if (!display_handler_) {
57 return;
58 }
59
60 if (!bitmap_ || bitmap_->size().width() != frame->size().width() ||
61 bitmap_->size().height() != frame->size().height()) {
62 // Allocate a new Bitmap, store references here, and pass it to Java.
63 JNIEnv* env = base::android::AttachCurrentThread();
64
65 // |bitmap_| must be deleted before |bitmap_global_ref_| is released.
66 bitmap_.reset();
67 bitmap_global_ref_.Reset(
68 env, display_handler_
69 ->NewBitmap(frame->size().width(), frame->size().height())
70 .obj());
71 bitmap_.reset(new gfx::JavaBitmap(bitmap_global_ref_.obj()));
72 display_handler_->UpdateFrameBitmap(bitmap_global_ref_);
73 }
74
75 // Copy pixels from |frame| into the Java Bitmap.
76 // TODO(lambroslambrou): Optimize away this copy by having the VideoDecoder
77 // decode directly into the Bitmap's pixel memory. This currently doesn't
78 // work very well because the VideoDecoder writes the decoded data in BGRA,
79 // and then the R/B channels are swapped in place (on the decoding thread).
80 // If a repaint is triggered from a Java event handler, the unswapped pixels
81 // can sometimes appear on the display.
82 uint8_t* dest_buffer = static_cast<uint8_t*>(bitmap_->pixels());
83 webrtc::DesktopRect buffer_rect =
84 webrtc::DesktopRect::MakeSize(frame->size());
85 for (webrtc::DesktopRegion::Iterator i(frame->updated_region()); !i.IsAtEnd();
86 i.Advance()) {
87 CopyRGB32Rect(frame->data(), frame->stride(), buffer_rect, dest_buffer,
88 bitmap_->stride(), buffer_rect, i.rect());
89 }
90
91 display_handler_->RedrawCanvas();
92 }
93
94 JniVideoRenderer::JniVideoRenderer(
95 ChromotingJniRuntime* jni_runtime,
96 base::WeakPtr<JniDisplayHandler> display)
97 : jni_runtime_(jni_runtime),
98 software_video_renderer_(this),
99 renderer_(new Renderer(jni_runtime, display)),
100 weak_factory_(this) {}
101
102 JniVideoRenderer::~JniVideoRenderer() {
103 jni_runtime_->display_task_runner()->DeleteSoon(FROM_HERE,
104 renderer_.release());
105 }
106
107 std::unique_ptr<webrtc::DesktopFrame> JniVideoRenderer::AllocateFrame(
108 const webrtc::DesktopSize& size) {
109 return base::WrapUnique(new webrtc::BasicDesktopFrame(size));
110 }
111
112 void JniVideoRenderer::DrawFrame(std::unique_ptr<webrtc::DesktopFrame> frame,
113 const base::Closure& done) {
114 DCHECK(jni_runtime_->network_task_runner()->BelongsToCurrentThread());
115
116 jni_runtime_->display_task_runner()->PostTaskAndReply(
117 FROM_HERE,
118 base::Bind(&Renderer::RenderFrame, base::Unretained(renderer_.get()),
119 base::Passed(&frame)),
120 base::Bind(&JniVideoRenderer::OnFrameRendered, weak_factory_.GetWeakPtr(),
121 done));
122 }
123
124 void JniVideoRenderer::OnFrameRendered(const base::Closure& done) {
125 DCHECK(jni_runtime_->network_task_runner()->BelongsToCurrentThread());
126
127 if (!done.is_null())
128 done.Run();
129 }
130
131 protocol::FrameConsumer::PixelFormat JniVideoRenderer::GetPixelFormat() {
132 return FORMAT_RGBA;
133 }
134
135 bool JniVideoRenderer::Initialize(
136 const ClientContext& context,
137 protocol::FrameStatsConsumer* stats_consumer) {
138 return software_video_renderer_.Initialize(context, stats_consumer);
139 }
140
141 void JniVideoRenderer::OnSessionConfig(const protocol::SessionConfig& config) {
142 return software_video_renderer_.OnSessionConfig(config);
143 }
144
145 protocol::VideoStub* JniVideoRenderer::GetVideoStub() {
146 return software_video_renderer_.GetVideoStub();
147 }
148
149 protocol::FrameConsumer* JniVideoRenderer::GetFrameConsumer() {
150 return software_video_renderer_.GetFrameConsumer();
151 }
152
153 protocol::FrameStatsConsumer* JniVideoRenderer::GetFrameStatsConsumer() {
154 return software_video_renderer_.GetFrameStatsConsumer();
155 }
156
157 } // namespace remoting
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698