Change password update infobar design according to current mocks.

Change password update infobar design according to current mocks.

On CL https://codereview.chromium.org/1490193003 it was implemented an update password infobar on Android. It turned out that a dropdown for choosing usernames couldn't be anchored to link in a text, that led to strange UI experience on some devices (depending on screen size) when the dropdown appeared in other part of screen.

This CL changes design a little bit, namely usernames now not inside text but in separate control - in textview for 1 account case and in spinner for multiple account case.

BUG=564674
Committed: https://crrev.com/24a2a02d13b26dde85bb69408c132a7cc0f839e0
Cr-Commit-Position: refs/heads/master@{#414076}

[dvadym, 2016-08-18 12:17:05]

Description was changed from

==========
Implementation of new password update bubble design.



BUG=None
==========

to

==========
Implementation of new password update infobar design.

On CL https://codereview.chromium.org/2256653002/ it was implemented an update
password infobar on Android. It turned out that a dropdown for choosing
usernames couldn't be anchored to link in a text, that led to strange UI
experience on some devices (depending on screen size) when the dropdown appeared
in other part of screen.

This CL changes design a little bit, namely usernames now not inside text but in
separate control - in textview for 1 account case and in spinner for multiple
account case.

BUG=564674
==========

[dvadym, 2016-08-18 12:18:03]

Description was changed from

==========
Implementation of new password update infobar design.

On CL https://codereview.chromium.org/2256653002/ it was implemented an update
password infobar on Android. It turned out that a dropdown for choosing
usernames couldn't be anchored to link in a text, that led to strange UI
experience on some devices (depending on screen size) when the dropdown appeared
in other part of screen.

This CL changes design a little bit, namely usernames now not inside text but in
separate control - in textview for 1 account case and in spinner for multiple
account case.

BUG=564674
==========

to

==========
Change password update infobar design according to current mock.

On CL https://codereview.chromium.org/2256653002/ it was implemented an update
password infobar on Android. It turned out that a dropdown for choosing
usernames couldn't be anchored to link in a text, that led to strange UI
experience on some devices (depending on screen size) when the dropdown appeared
in other part of screen.

This CL changes design a little bit, namely usernames now not inside text but in
separate control - in textview for 1 account case and in spinner for multiple
account case.

BUG=564674
==========

[dvadym, 2016-08-18 12:18:20]

Description was changed from

==========
Change password update infobar design according to current mock.

On CL https://codereview.chromium.org/2256653002/ it was implemented an update
password infobar on Android. It turned out that a dropdown for choosing
usernames couldn't be anchored to link in a text, that led to strange UI
experience on some devices (depending on screen size) when the dropdown appeared
in other part of screen.

This CL changes design a little bit, namely usernames now not inside text but in
separate control - in textview for 1 account case and in spinner for multiple
account case.

BUG=564674
==========

to

==========
Change password update infobar design according to current mocks.

On CL https://codereview.chromium.org/2256653002/ it was implemented an update
password infobar on Android. It turned out that a dropdown for choosing
usernames couldn't be anchored to link in a text, that led to strange UI
experience on some devices (depending on screen size) when the dropdown appeared
in other part of screen.

This CL changes design a little bit, namely usernames now not inside text but in
separate control - in textview for 1 account case and in spinner for multiple
account case.

BUG=564674
==========

[dvadym, 2016-08-18 16:55:09]

Description was changed from

==========
Change password update infobar design according to current mocks.

On CL https://codereview.chromium.org/2256653002/ it was implemented an update
password infobar on Android. It turned out that a dropdown for choosing
usernames couldn't be anchored to link in a text, that led to strange UI
experience on some devices (depending on screen size) when the dropdown appeared
in other part of screen.

This CL changes design a little bit, namely usernames now not inside text but in
separate control - in textview for 1 account case and in spinner for multiple
account case.

BUG=564674
==========

to

==========
Change password update infobar design according to current mocks.

On CL https://codereview.chromium.org/1490193003 it was implemented an update
password infobar on Android. It turned out that a dropdown for choosing
usernames couldn't be anchored to link in a text, that led to strange UI
experience on some devices (depending on screen size) when the dropdown appeared
in other part of screen.

This CL changes design a little bit, namely usernames now not inside text but in
separate control - in textview for 1 account case and in spinner for multiple
account case.

BUG=564674
==========

[dvadym, 2016-08-18 17:00:10]

dvadym@chromium.org changed reviewers:
+ dfalcantara@chromium.org, melandory@chromium.org

[dvadym, 2016-08-18 17:00:11]

dfalcantara@chromium.org: Could you please review chrome/android/* and
chrome/browser/ui/android/infobars/update_password_infobar.cc?

melandory@chromium.org: Could you please review
chrome/browser/password_manager/update_password_infobar_delegate_android.cc?

[gone, 2016-08-18 17:01:54]

Can you send links to the mock and screenshots of what your CL does?

[dvadym, 2016-08-19 09:51:26]

On 2016/08/18 17:01:54, dfalcantara wrote:
> Can you send links to the mock and screenshots of what your CL does?

Sorry, I forgot about mocks. I've sent you an e-mail.

[gone, 2016-08-19 17:59:17]

In general the code seems fine, which is why I'm confused about why your spinner
seems to have an additional margin on it -- it doesn't line up on the left or
right like the translate panel's spinners (Seen here:
https://drive.google.com/open?id=0B7c8ZkXVwskDTFQ0R1ZMbTZUVlU)

In my screenshot, the spinner boxes on the left line up correctly, and the
spinner's arrows line up with the X.  Can you take a similar picture?  You'd
need to set "Developer options -> Show layout bounds" on in Android's Settings.

I *think* not lining up on the left is caused by the DualControlLayout expecting
your spinners to always have labels (which the infobar mock suggested was the
case).

Assuming that's the case, *and you want to try it out yourself*, these changing
these lines in DualControlLayout#onMeasure() might fix your problem:

=====

150 int combinedWidth = mPrimaryView.getMeasuredWidth()
            + mHorizontalMarginBetweenViews + mSecondaryView.getMeasuredWidth();

to this:

    int combinedWidth = mPrimaryView.getMeasuredWidth() +
mSecondaryView.getMeasuredWidth();
    if (mPrimaryView.getMeasuredWidth() > 0 && mSecondaryView.getMeasuredWidth()
> 0) {
        combinedWidth += mHorizontalMarginBetweenViews;
    }

=====

This:

217 secondaryRight = primaryLeft - mHorizontalMarginBetweenViews;

to this:

    secondaryRight = primaryLeft;
    if (mPrimaryView.getMeasuredWidth() > 0) secondaryRight -=
mHorizontalMarginBetweenViews;

=====

And this:

221 secondaryLeft = primaryRight + mHorizontalMarginBetweenViews;

to this:
    secondaryLeft = primaryRight;
    if (mPrimaryView.getMeasuredWidth() > 0) secondaryLeft +=
mHorizontalMarginBetweenViews;

https://codereview.chromium.org/2256653002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarControlLayout.java
(right):

https://codereview.chromium.org/2256653002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarControlLayout.java:61:
mLabel = "";
can this be null?

[dvadym, 2016-08-22 18:22:39]

Thanks Dan for explanation how to fix this, I did as you wrote and it works
(screenshots in e-mail). PTAL

https://codereview.chromium.org/2256653002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarControlLayout.java
(right):

https://codereview.chromium.org/2256653002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarControlLayout.java:61:
mLabel = "";
On 2016/08/19 17:59:17, dfalcantara wrote:
> can this be null?

Done.

[gone, 2016-08-23 15:49:21]

Cool beans.  The gigantic down arrow seems to be a big tablet thing, so I guess
it's a theming thing.

lgtm

[dvadym, 2016-08-24 09:34:31]

dvadym@chromium.org changed reviewers:
+ vabr@chromium.org

[dvadym, 2016-08-24 09:34:32]

Hi Vaclav,

 Could you please review changes in 
chrome/browser/password_manager/update_password_infobar_delegate_android.cc?

Regards,
Vadym

[vabr (Chromium), 2016-08-24 10:18:36]

chrome/browser/password_manager/update_password_infobar_delegate_android.cc
LGTM!
Vaclav

[dvadym, 2016-08-24 10:46:23]

The CQ bit was checked by dvadym@chromium.org

[commit-bot: I haz the power, 2016-08-24 10:46:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 12:00:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 12:00:19]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[dvadym, 2016-08-24 13:54:32]

The CQ bit was checked by dvadym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 13:54:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 14:29:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 14:29:49]

Dry run: This issue passed the CQ dry run.

[dvadym, 2016-08-24 15:10:52]

The CQ bit was checked by dvadym@chromium.org

[dvadym, 2016-08-24 15:10:52]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org,
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2256653002/#ps120001
(title: "Removed unused variables")

[commit-bot: I haz the power, 2016-08-24 15:11:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 15:15:43]

Description was changed from

==========
Change password update infobar design according to current mocks.

On CL https://codereview.chromium.org/1490193003 it was implemented an update
password infobar on Android. It turned out that a dropdown for choosing
usernames couldn't be anchored to link in a text, that led to strange UI
experience on some devices (depending on screen size) when the dropdown appeared
in other part of screen.

This CL changes design a little bit, namely usernames now not inside text but in
separate control - in textview for 1 account case and in spinner for multiple
account case.

BUG=564674
==========

to

==========
Change password update infobar design according to current mocks.

On CL https://codereview.chromium.org/1490193003 it was implemented an update
password infobar on Android. It turned out that a dropdown for choosing
usernames couldn't be anchored to link in a text, that led to strange UI
experience on some devices (depending on screen size) when the dropdown appeared
in other part of screen.

This CL changes design a little bit, namely usernames now not inside text but in
separate control - in textview for 1 account case and in spinner for multiple
account case.

BUG=564674
==========

[commit-bot: I haz the power, 2016-08-24 15:15:44]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-08-24 15:18:11]

Description was changed from

==========
Change password update infobar design according to current mocks.

On CL https://codereview.chromium.org/1490193003 it was implemented an update
password infobar on Android. It turned out that a dropdown for choosing
usernames couldn't be anchored to link in a text, that led to strange UI
experience on some devices (depending on screen size) when the dropdown appeared
in other part of screen.

This CL changes design a little bit, namely usernames now not inside text but in
separate control - in textview for 1 account case and in spinner for multiple
account case.

BUG=564674
==========

to

==========
Change password update infobar design according to current mocks.

On CL https://codereview.chromium.org/1490193003 it was implemented an update
password infobar on Android. It turned out that a dropdown for choosing
usernames couldn't be anchored to link in a text, that led to strange UI
experience on some devices (depending on screen size) when the dropdown appeared
in other part of screen.

This CL changes design a little bit, namely usernames now not inside text but in
separate control - in textview for 1 account case and in spinner for multiple
account case.

BUG=564674

Committed: https://crrev.com/24a2a02d13b26dde85bb69408c132a7cc0f839e0
Cr-Commit-Position: refs/heads/master@{#414076}
==========

[commit-bot: I haz the power, 2016-08-24 15:18:13]

Patchset 7 (id:??) landed as
https://crrev.com/24a2a02d13b26dde85bb69408c132a7cc0f839e0
Cr-Commit-Position: refs/heads/master@{#414076}