chrome/browser/password_manager/update_password_infobar_delegate_android.cc - Issue 2256653002: Change password update infobar design according to current mocks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/update_password_infobar_delegate_android.cc

Issue 2256653002: Change password update infobar design according to current mocks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed unused variables Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/strings/android_chrome_strings.grd ('k') | chrome/browser/ui/android/infobars/update_password_infobar.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/update_password_infobar_delegate_android.cc

diff --git a/chrome/browser/password_manager/update_password_infobar_delegate_android.cc b/chrome/browser/password_manager/update_password_infobar_delegate_android.cc

index 9fcb4792a608c1c716a2334a065993442440d991..9ddda12e4331b8323acf8e562acda7f397f6f1b6 100644

--- a/chrome/browser/password_manager/update_password_infobar_delegate_android.cc

+++ b/chrome/browser/password_manager/update_password_infobar_delegate_android.cc

@@ -62,6 +62,15 @@ UpdatePasswordInfoBarDelegate::UpdatePasswordInfoBarDelegate(

std::unique_ptr<password_manager::PasswordFormManager> form_to_update,

bool is_smartlock_branding_enabled)

: is_smartlock_branding_enabled_(is_smartlock_branding_enabled) {

+ base::string16 message;

+ gfx::Range message_link_range = gfx::Range();

+ GetSavePasswordDialogTitleTextAndLinkRange(

+ web_contents->GetVisibleURL(), form_to_update->observed_form().origin,

+ is_smartlock_branding_enabled, PasswordTittleType::UPDATE_PASSWORD,

+ &message, &message_link_range);

+ SetMessage(message);

+ SetMessageLinkRange(message_link_range);

// TODO(melandory): Add histograms, crbug.com/577129

passwords_state_.set_client(

ChromePasswordManagerClient::FromWebContents(web_contents));