chrome/browser/ui/views/omnibox/omnibox_view_views.cc - Issue 2256613002: Remove ShowURL/HideURL from OmniboxView and LocationBarView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Issue 2256613002: Remove ShowURL/HideURL from OmniboxView and LocationBarView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_search_terms

Patch Set: rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/location_bar/location_bar_view.cc ('k') | chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

index 3fc852169021d7d3d8c1672a200a78a464f4560d..b28def07e37abcb05b22fc45046d3db12cde6e3f 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

@@ -354,9 +354,6 @@ void OmniboxViewViews::ExecuteCommand(int command_id, int event_flags) {

case IDS_PASTE_AND_GO:

model()->PasteAndGo(GetClipboardText());

return;

- case IDS_SHOW_URL:

- controller()->ShowURL();

- return;

case IDC_EDIT_SEARCH_ENGINES:

location_bar_view_->command_updater()->ExecuteCommand(command_id);

return;

@@ -812,9 +809,6 @@ bool OmniboxViewViews::IsCommandIdEnabled(int command_id) const {

return !read_only() && !GetClipboardText().empty();

if (command_id == IDS_PASTE_AND_GO)

return !read_only() && model()->CanPasteAndGo(GetClipboardText());

- // TODO(treib): Completely remove IDS_SHOW_URL. crbug.com/627747

- if (command_id == IDS_SHOW_URL)

- return false;

return Textfield::IsCommandIdEnabled(command_id) ||

location_bar_view_->command_updater()->IsCommandEnabled(command_id);

}