Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: components/offline_pages/background/request_coordinator.cc

Issue 2256373002: Adds request queue removal capability to OfflinePageBridge. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@query-queue
Patch Set: Add a comment. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_coordinator.cc
diff --git a/components/offline_pages/background/request_coordinator.cc b/components/offline_pages/background/request_coordinator.cc
index 88ebb6092d655506a1fd9a701bb813f1639ce229..be0e6650639c1b5264c6f533252e6e706c6ceade 100644
--- a/components/offline_pages/background/request_coordinator.cc
+++ b/components/offline_pages/background/request_coordinator.cc
@@ -113,10 +113,12 @@ void RequestCoordinator::GetQueuedRequestsCallback(
}
void RequestCoordinator::RemoveRequests(
- const std::vector<int64_t>& request_ids) {
- queue_->RemoveRequests(request_ids,
- base::Bind(&RequestCoordinator::RemoveRequestsCallback,
- weak_ptr_factory_.GetWeakPtr()));
+ const std::vector<int64_t>& request_ids,
+ const RequestsRemovedCallback& callback) {
+ queue_->RemoveRequests(
+ request_ids,
+ base::Bind(&RequestCoordinator::ExplicitlyRemoveRequestsCallback,
+ weak_ptr_factory_.GetWeakPtr(), callback));
}
void RequestCoordinator::PauseRequests(
@@ -164,6 +166,14 @@ void RequestCoordinator::UpdateMultipleRequestsCallback(
NotifyChanged(request);
}
+void RequestCoordinator::ExplicitlyRemoveRequestsCallback(
dougarnett 2016/08/19 19:35:59 arrgh, 3 callbacks to name and not be confused by.
dewittj 2016/08/19 20:21:17 Any suggestions for now?
dougarnett 2016/08/19 20:32:10 Wonder about: RemoveRequestsCallback => HandleRem
+ const RequestsRemovedCallback& callback,
+ const RequestQueue::UpdateMultipleRequestResults& results,
+ const std::vector<SavePageRequest>& requests) {
+ RemoveRequestsCallback(results, requests);
+ callback.Run(requests);
+}
+
void RequestCoordinator::RemoveRequestsCallback(
const RequestQueue::UpdateMultipleRequestResults& results,
const std::vector<SavePageRequest>& requests) {

Powered by Google App Engine
This is Rietveld 408576698