Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Unified Diff: components/offline_pages/background/request_coordinator_unittest.cc

Issue 2256373002: Adds request queue removal capability to OfflinePageBridge. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@query-queue
Patch Set: Add a comment. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_coordinator_unittest.cc
diff --git a/components/offline_pages/background/request_coordinator_unittest.cc b/components/offline_pages/background/request_coordinator_unittest.cc
index 41393a47f6dd97cef81d1234cae0b53e2d9501b4..adec21875cf2c1ee9c45ea9ddfd01737b6a3a595 100644
--- a/components/offline_pages/background/request_coordinator_unittest.cc
+++ b/components/offline_pages/background/request_coordinator_unittest.cc
@@ -214,6 +214,9 @@ class RequestCoordinatorTest
void GetRequestsDone(RequestQueue::GetRequestsResult result,
const std::vector<SavePageRequest>& requests);
+ // Callback for removing requests.
+ void RemoveRequestsDone(const std::vector<SavePageRequest>& requests);
+
// Callback for getting request statuses.
void GetQueuedRequestsDone(const std::vector<SavePageRequest>& requests);
@@ -304,6 +307,12 @@ void RequestCoordinatorTest::GetRequestsDone(
last_requests_ = requests;
}
+void RequestCoordinatorTest::RemoveRequestsDone(
+ const std::vector<SavePageRequest>& requests) {
+ last_requests_ = requests;
+ waiter_.Signal();
+}
+
void RequestCoordinatorTest::GetQueuedRequestsDone(
const std::vector<SavePageRequest>& requests) {
last_requests_ = requests;
@@ -755,7 +764,7 @@ TEST_F(RequestCoordinatorTest, PauseAndResumeObserver) {
EXPECT_EQ(SavePageRequest::RequestState::AVAILABLE, observer().state());
}
-TEST_F(RequestCoordinatorTest, ObserverdRemoveRequest) {
+TEST_F(RequestCoordinatorTest, RemoveRequest) {
// Add a request to the queue.
offline_pages::SavePageRequest request1(kRequestId1, kUrl1, kClientId1,
base::Time::Now(), kUserRequested);
@@ -767,12 +776,19 @@ TEST_F(RequestCoordinatorTest, ObserverdRemoveRequest) {
// Remove the request.
std::vector<int64_t> request_ids;
request_ids.push_back(kRequestId1);
- coordinator()->RemoveRequests(request_ids);
+ coordinator()->RemoveRequests(
+ request_ids, base::Bind(&RequestCoordinatorTest::RemoveRequestsDone,
+ base::Unretained(this)));
+
+ PumpLoop();
+ WaitForCallback();
PumpLoop();
EXPECT_TRUE(observer().completed_called());
EXPECT_EQ(RequestCoordinator::SavePageStatus::REMOVED,
observer().last_status());
+ EXPECT_EQ(1UL, last_requests().size());
+ EXPECT_EQ(kRequestId1, last_requests().at(0).request_id());
}
} // namespace offline_pages

Powered by Google App Engine
This is Rietveld 408576698