Adds request queue removal capability to OfflinePageBridge.

components/offline_pages/background/request_coordinator.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/background/request_coordinator.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 95 matching lines @@
 }
 
 void RequestCoordinator::GetQueuedRequestsCallback(
     const GetRequestsCallback& callback,
     RequestQueue::GetRequestsResult result,
     const std::vector<SavePageRequest>& requests) {
   callback.Run(requests);
 }
 
 void RequestCoordinator::RemoveRequests(
-    const std::vector<int64_t>& request_ids) {
-  queue_->RemoveRequests(request_ids,
-                         base::Bind(&RequestCoordinator::RemoveRequestsCallback,
-                                    weak_ptr_factory_.GetWeakPtr()));
+    const std::vector<int64_t>& request_ids,
+    const RequestsRemovedCallback& callback) {
+  queue_->RemoveRequests(
+      request_ids,
+      base::Bind(&RequestCoordinator::ExplicitlyRemoveRequestsCallback,
+                 weak_ptr_factory_.GetWeakPtr(), callback));
 }
 
 void RequestCoordinator::PauseRequests(
     const std::vector<int64_t>& request_ids) {
   queue_->ChangeRequestsState(
       request_ids, SavePageRequest::RequestState::PAUSED,
       base::Bind(&RequestCoordinator::UpdateMultipleRequestsCallback,
                  weak_ptr_factory_.GetWeakPtr()));
 }
 
@@ skipping 27 matching lines @@
 }
 
 // Called in response to updating multiple requests in the request queue.
 void RequestCoordinator::UpdateMultipleRequestsCallback(
     const RequestQueue::UpdateMultipleRequestResults& results,
     const std::vector<SavePageRequest>& requests) {
   for (SavePageRequest request : requests)
     NotifyChanged(request);
 }
 
+void RequestCoordinator::ExplicitlyRemoveRequestsCallback(

[dougarnett, 2016/08/19 19:35:59]

arrgh, 3 callbacks to name and not be confused by. Maybe Pete and I can improve
naming in a follow up.

[dewittj, 2016/08/19 20:21:17]

Any suggestions for now?

[dougarnett, 2016/08/19 20:32:10]

Wonder about:

RemoveRequestsCallback => HandleRemovedRequests
ExplicitlyRemoveRequestsCallback => HandleRemovedRequestsAndCallback
RequestsRemovedCallback => RemoveRequestsCallback

+    const RequestsRemovedCallback& callback,
+    const RequestQueue::UpdateMultipleRequestResults& results,
+    const std::vector<SavePageRequest>& requests) {
+  RemoveRequestsCallback(results, requests);
+  callback.Run(requests);
+}
+
 void RequestCoordinator::RemoveRequestsCallback(
     const RequestQueue::UpdateMultipleRequestResults& results,
     const std::vector<SavePageRequest>& requests) {
   for (SavePageRequest request : requests)
     NotifyCompleted(request, SavePageStatus::REMOVED);
 }
 
 void RequestCoordinator::StopProcessing() {
   is_canceled_ = true;
   if (offliner_ && is_busy_) {
@@ skipping 228 matching lines @@
   FOR_EACH_OBSERVER(Observer, observers_, OnChanged(request));
 }
 
 void RequestCoordinator::GetOffliner() {
   if (!offliner_) {
     offliner_ = factory_->GetOffliner(policy_.get());
   }
 }
 
 }  // namespace offline_pages