[perf] Refactor chromium.perf.fyi recipe config to reuse chromium.perf code.

[perf] Refactor chromium.perf.fyi recipe config to reuse chromium.perf code.

Move chromium and gclient configs into the places where they're used.
Remove max_battery_temp parameter and just use the default value.
No expectations changes.

Committed: https://chromium.googlesource.com/chromium/tools/build/+/98386b54b8e1b13372a4d578f7f51a6ccaa4b759

[dtu, 2016-08-18 05:46:45]

Description was changed from

==========
Refactor chromium.perf.fyi recipe config to reuse chromium.perf code.
==========

to

==========
Refactor chromium.perf.fyi recipe config to reuse chromium.perf code.

Move chromium and gclient configs into the places where they're used.
==========

[dtu, 2016-08-18 05:46:46]

dtu@chromium.org changed reviewers:
+ iannucci@chromium.org, robertocn@chromium.org

[dtu, 2016-08-18 05:47:04]

Description was changed from

==========
Refactor chromium.perf.fyi recipe config to reuse chromium.perf code.

Move chromium and gclient configs into the places where they're used.
==========

to

==========
Refactor chromium.perf.fyi recipe config to reuse chromium.perf code.

Move chromium and gclient configs into the places where they're used.
No expectations changes.
==========

[dtu, 2016-08-18 05:47:32]

Description was changed from

==========
Refactor chromium.perf.fyi recipe config to reuse chromium.perf code.

Move chromium and gclient configs into the places where they're used.
No expectations changes.
==========

to

==========
[perf] Refactor chromium.perf.fyi recipe config to reuse chromium.perf code.

Move chromium and gclient configs into the places where they're used.
No expectations changes.
==========

[iannucci, 2016-08-18 09:39:30]

lgtm

[dtu, 2016-08-18 19:53:11]

The CQ bit was checked by dtu@chromium.org

[commit-bot: I haz the power, 2016-08-18 19:53:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 20:00:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 20:00:25]

Try jobs failed on following builders:
  Build Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/30b808a7e7ccc310)

[RobertoCN, 2016-08-19 20:47:26]

Nothing but nits. LGTM

https://codereview.chromium.org/2256123002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_perf.py (right):

https://codereview.chromium.org/2256123002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_perf.py:92: perf_id,
platform, target_bits, max_battery_temp=350,
Nit: Why? Is there a link to the reasoning behind this?

https://codereview.chromium.org/2256123002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py (right):

https://codereview.chromium.org/2256123002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py:46: 
nit: 2 blank lines seem sufficient.

[dtu, 2016-08-19 23:40:23]

Description was changed from

==========
[perf] Refactor chromium.perf.fyi recipe config to reuse chromium.perf code.

Move chromium and gclient configs into the places where they're used.
No expectations changes.
==========

to

==========
[perf] Refactor chromium.perf.fyi recipe config to reuse chromium.perf code.

Move chromium and gclient configs into the places where they're used.
Remove max_battery_temp parameter and just use the default value.
No expectations changes.
==========

[dtu, 2016-08-19 23:40:28]

https://codereview.chromium.org/2256123002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_perf.py (right):

https://codereview.chromium.org/2256123002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_perf.py:92: perf_id,
platform, target_bits, max_battery_temp=350,
On 2016/08/19 20:47:26, RobertoCN wrote:
> Nit: Why? Is there a link to the reasoning behind this?

I moved the default value from _AddTestSpec to here to eliminate the parameter,
because there isn't a known case where we'd want to customize the value per-bot.
The YAGNI principle; thanks TotT!

https://codereview.chromium.org/2256123002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py (right):

https://codereview.chromium.org/2256123002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py:46: 
On 2016/08/19 20:47:26, RobertoCN wrote:
> nit: 2 blank lines seem sufficient.

Done.

[dtu, 2016-08-19 23:40:36]

The CQ bit was checked by dtu@chromium.org

[dtu, 2016-08-19 23:40:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertocn@chromium.org, iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/2256123002/#ps20001
(title: "Remove extra space")

[commit-bot: I haz the power, 2016-08-19 23:40:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 23:44:28]

Description was changed from

==========
[perf] Refactor chromium.perf.fyi recipe config to reuse chromium.perf code.

Move chromium and gclient configs into the places where they're used.
Remove max_battery_temp parameter and just use the default value.
No expectations changes.
==========

to

==========
[perf] Refactor chromium.perf.fyi recipe config to reuse chromium.perf code.

Move chromium and gclient configs into the places where they're used.
Remove max_battery_temp parameter and just use the default value.
No expectations changes.

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/98386b54b8e1b13372a4...
==========

[commit-bot: I haz the power, 2016-08-19 23:44:31]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/98386b54b8e1b13372a4...