Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Unified Diff: scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_perf.py

Issue 2256123002: [perf] Refactor chromium.perf.fyi recipe config to reuse chromium.perf code. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Remove extra space Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_perf.py
diff --git a/scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_perf.py b/scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_perf.py
index ddcd3997fb9c81b658c5ff6a0a4639e335493d9f..d3f8ce1fcfe68752aa80f6d61ee2d069dafb2742 100644
--- a/scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_perf.py
+++ b/scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_perf.py
@@ -5,14 +5,9 @@
from . import chromium_perf
import DEPS
-CONFIG_CTX = DEPS['gclient'].CONFIG_CTX
+CHROMIUM_CONFIG_CTX = DEPS['chromium'].CONFIG_CTX
+GCLIENT_CONFIG_CTX = DEPS['gclient'].CONFIG_CTX
-@CONFIG_CTX(includes=['chromium_perf'])
-def tryserver_chromium_perf(c):
- soln = c.solutions.add()
- soln.name = 'catapult'
- soln.url = ('https://chromium.googlesource.com/external/github.com/'
- 'catapult-project/catapult.git')
SPEC = {
'builders': {},
@@ -20,6 +15,21 @@ SPEC = {
}
+@CHROMIUM_CONFIG_CTX(includes=['chromium_perf', 'goma_hermetic_fallback'])
+def tryserver_chromium_perf(c):
+ # Bisects may build using old toolchains, so goma_hermetic_fallback is
+ # required. See https://codereview.chromium.org/1015633002
+ pass
+
+
+@GCLIENT_CONFIG_CTX(includes=['chromium_perf'])
+def tryserver_chromium_perf(c):
+ soln = c.solutions.add()
+ soln.name = 'catapult'
+ soln.url = ('https://chromium.googlesource.com/external/github.com/'
+ 'catapult-project/catapult.git')
+
+
def _AddBuildSpec(name, platform, target_bits=64):
SPEC['builders'][name] = chromium_perf.BuildSpec(
'tryserver_chromium_perf', None, platform, target_bits)
« no previous file with comments | « scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698