[perf] Refactor chromium.perf.fyi recipe config to reuse chromium.perf code.

scripts/slave/recipe_modules/chromium_tests/chromium_perf.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import collections
 
 from . import steps
 
+import DEPS
+CHROMIUM_CONFIG_CTX = DEPS['chromium'].CONFIG_CTX
+GCLIENT_CONFIG_CTX = DEPS['gclient'].CONFIG_CTX
 
-_builders = collections.defaultdict(dict)
+
+builders = collections.defaultdict(dict)
 
 
 SPEC = {
   'builders': {},
   'settings': {
     'build_gs_bucket': 'chrome-perf',
     # Bucket for storing builds for manual bisect
     'bisect_build_gs_bucket': 'chrome-test-builds',
     'bisect_build_gs_extra': 'official-by-commit',
     'bisect_builders': []
   },
 }
 
 
+@CHROMIUM_CONFIG_CTX(includes=['chromium', 'official', 'mb'])
+def chromium_perf(c):
+  c.clobber_before_runhooks = False
+  pass
+
+
 def _BaseSpec(bot_type, config_name, disable_tests,
               platform, target_bits, tests):
   spec = {
     'bot_type': bot_type,
     'chromium_config': config_name,
     'chromium_config_kwargs': {
       'BUILD_CONFIG': 'Release',
       'TARGET_BITS': target_bits,
     },
     'disable_tests': disable_tests,
@@ skipping 28 matching lines @@
       platform=platform,
       target_bits=target_bits,
       tests=tests,
   )
 
   spec['compile_targets'] = ['chromium_builder_perf']
 
   return spec
 
 
-def _TestSpec(config_name, parent_builder, perf_id, platform, target_bits,
-              max_battery_temp, shard_index, num_host_shards,
-              num_device_shards):
+def TestSpec(config_name, parent_buildername, perf_id, platform, target_bits,
+              shard_index, num_host_shards, num_device_shards):
   spec = _BaseSpec(
       bot_type='tester',
       config_name=config_name,
       disable_tests=platform == 'android',
       platform=platform,
       target_bits=target_bits,
       tests=[steps.DynamicPerfTests(
-        perf_id, platform, target_bits, max_battery_temp=max_battery_temp,
+        perf_id, platform, target_bits, max_battery_temp=350,
         num_device_shards=num_device_shards, num_host_shards=num_host_shards,
         shard_index=shard_index)],
   )
 
-  spec['parent_buildername'] = parent_builder
+  spec['parent_buildername'] = parent_buildername
   spec['perf-id'] = perf_id
   spec['results-url'] = 'https://chromeperf.appspot.com'
 
   if platform != 'android':
     # TODO: Remove disable_tests and run test_generators on Android.
     spec['test_generators'] = [steps.generate_script]
     spec['test_spec_file'] = 'chromium.perf.json'
 
   return spec
 
 
 def _AddBuildSpec(name, platform, target_bits=64, add_to_bisect=False):
   if target_bits == 64:
     perf_id = platform
   else:
     perf_id = '%s-%d' % (platform, target_bits)
 
   SPEC['builders'][name] = BuildSpec(
       'chromium_perf', perf_id, platform, target_bits)
-  assert target_bits not in _builders[platform]
-  _builders[platform][target_bits] = name
+  assert target_bits not in builders[platform]
+  builders[platform][target_bits] = name
   if add_to_bisect:
     SPEC['settings']['bisect_builders'].append(name)
 
 
 def _AddTestSpec(name, perf_id, platform, target_bits=64,
-                 max_battery_temp=350, num_host_shards=1, num_device_shards=1):
-  parent_builder = _builders[platform][target_bits]
+                 num_host_shards=1, num_device_shards=1):
+  parent_buildername = builders[platform][target_bits]
   for shard_index in xrange(num_host_shards):
     builder_name = '%s (%d)' % (name, shard_index + 1)
-    SPEC['builders'][builder_name] = _TestSpec(
-        'chromium_perf', parent_builder, perf_id, platform, target_bits,
-        max_battery_temp, shard_index, num_host_shards, num_device_shards)
+    SPEC['builders'][builder_name] = TestSpec(
+        'chromium_perf', parent_buildername, perf_id, platform, target_bits,
+        shard_index, num_host_shards, num_device_shards)
 
 
 _AddBuildSpec('Android Builder', 'android', target_bits=32)
 _AddBuildSpec('Android arm64 Builder', 'android')
 _AddBuildSpec('Win Builder', 'win', target_bits=32)
 _AddBuildSpec('Win x64 Builder', 'win')
 _AddBuildSpec('Mac Builder', 'mac')
 _AddBuildSpec('Linux Builder', 'linux', add_to_bisect=True)
 
 
@@ skipping 36 matching lines @@
 _AddTestSpec('Mac 10.10 Perf', 'chromium-rel-mac10', 'mac',
              num_host_shards=5)
 _AddTestSpec('Mac Retina Perf', 'chromium-rel-mac-retina', 'mac',
              num_host_shards=5)
 _AddTestSpec('Mac HDD Perf', 'chromium-rel-mac-hdd', 'mac',
              num_host_shards=5)
 
 
 _AddTestSpec('Linux Perf', 'linux-release', 'linux',
              num_host_shards=5)