Issue 2255543003: Merge to m53: Partial revert of change to make Notification Center focusable after alt+shift+n

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2255543003: Merge to m53: Partial revert of change to make Notification Center focusable after alt+shift+n (Closed)

Created:
4 years, 4 months ago by David Tseng

Modified:
4 years, 4 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

Merge to m53: Partial revert of change to make Notification Center focusable after alt+shift+n Reason for partial revert: See the bug for more comments. Original cl: https://codereview.chromium.org/2054473003 BUG=620801 TBR=xiyuan@chromium.org Review-Url: https://codereview.chromium.org/2242733003 Cr-Commit-Position: refs/heads/master@{#411723} (cherry picked from commit 86817289921e010c0e4a8595ea9be48730a45a04) Committed: https://chromium.googlesource.com/chromium/src/+/6b61b2b13a044d2aeef5d3a9a80204f7bf6e9ad9

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	ui/message_center/views/message_center_view.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

David Tseng

4 years, 4 months ago (2016-08-16 21:05:53 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6b61b2b13a044d2aeef5d3a9a80204f7bf6e9ad9 (presubmit successful).