Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2242733003: Partial revert of change to make Notification Center focusable after alt+shift+n (Closed)

Created:
4 years, 4 months ago by David Tseng
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Partial revert of change to make Notification Center focusable after alt+shift+n Reason for partial revert: See the bug for more comments. Original cl: https://codereview.chromium.org/2054473003 BUG=620801 TBR=xiyuan@chromium.org Committed: https://crrev.com/86817289921e010c0e4a8595ea9be48730a45a04 Cr-Commit-Position: refs/heads/master@{#411723}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M ui/message_center/views/message_center_view.cc View 1 chunk +10 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2242733003/1
4 years, 4 months ago (2016-08-12 17:53:21 UTC) #3
David Tseng
https://codereview.chromium.org/2242733003/diff/1/ui/message_center/views/message_center_view.cc File ui/message_center/views/message_center_view.cc (right): https://codereview.chromium.org/2242733003/diff/1/ui/message_center/views/message_center_view.cc#newcode532 ui/message_center/views/message_center_view.cc:532: scroller_->SetFocusBehavior(FocusBehavior::NEVER); Future note to xiyuan@ making this + scroller_->SetFocusBehavior(FocusBehavior::ACCESSIBLE_ONLY); ...
4 years, 4 months ago (2016-08-12 18:11:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 19:00:04 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 19:02:10 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/86817289921e010c0e4a8595ea9be48730a45a04
Cr-Commit-Position: refs/heads/master@{#411723}

Powered by Google App Engine
This is Rietveld 408576698