Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2054473003: Implement update notifications for ChromeVox Next. (Closed)

Created:
4 years, 6 months ago by David Tseng
Modified:
4 years, 6 months ago
Reviewers:
yoshiki, dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, mlamouri+watch-notifications_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, Peter Beverloo, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement update notifications for ChromeVox Next. - adds a notification on startup alerting the user to a new ChromeVox experience - adds a skeleton page to be filled with content for the transition intro/tutorial - fixes the alert output rule to ignore descendants in the output if the alert has a name - adds a new command to open the "new" or "next" announcements/release notes/tutorial - fixes two issues with the notification center: 1. the focus wasn't being placed on the first message view item 2. the scroll view parenting the message views was receiving focus but has no actionable functionality from the keyboard. Removed it from being focusable. The outcome is when hitting alt+shift+n, an actionable button gets focused with or wihtout a notification being present (do not disturb gets focus if there are no messages). Previously, alt+shift+n focused the scrollview, which has no name/role, so gave no meaningful feedback. BUG=618094 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/9e0f3f0f765bc0625c7988086d8e9ffefd97d337 Cr-Commit-Position: refs/heads/master@{#399051}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : rebase. #

Patch Set 5 : Fix test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -22 lines) Patch
M chrome/browser/resources/chromeos/chromevox/chromevox.gni View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/background.js View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/classic_keymap.json View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/user_commands.js View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/command_store.js View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/command_store_test.unitjs View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 1 2 3 3 chunks +8 lines, -2 lines 0 comments Download
A chrome/browser/resources/chromeos/chromevox/cvox2/background/next_update.html View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/chromevox/cvox2/background/notifications.js View 1 2 1 chunk +68 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/manifest.json.jinja2 View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M ui/message_center/views/message_center_bubble.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M ui/message_center/views/message_center_view.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
David Tseng
dmazzoni: entire cl yoshiki: message center related files.
4 years, 6 months ago (2016-06-08 19:07:17 UTC) #4
dmazzoni
lgtm but I don't know the ui/message_center code https://codereview.chromium.org/2054473003/diff/40001/chrome/browser/resources/chromeos/chromevox/common/command_store.js File chrome/browser/resources/chromeos/chromevox/common/command_store.js (right): https://codereview.chromium.org/2054473003/diff/40001/chrome/browser/resources/chromeos/chromevox/common/command_store.js#newcode158 chrome/browser/resources/chromeos/chromevox/common/command_store.js:158: 'showNextUpdatePage': ...
4 years, 6 months ago (2016-06-09 15:45:02 UTC) #6
yoshiki
the message center code lgtm
4 years, 6 months ago (2016-06-09 17:43:39 UTC) #7
David Tseng
https://codereview.chromium.org/2054473003/diff/40001/chrome/browser/resources/chromeos/chromevox/common/command_store.js File chrome/browser/resources/chromeos/chromevox/common/command_store.js (right): https://codereview.chromium.org/2054473003/diff/40001/chrome/browser/resources/chromeos/chromevox/common/command_store.js#newcode158 chrome/browser/resources/chromeos/chromevox/common/command_store.js:158: 'showNextUpdatePage': {announce: false}, On 2016/06/09 15:45:02, dmazzoni wrote: > ...
4 years, 6 months ago (2016-06-09 18:47:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054473003/80001
4 years, 6 months ago (2016-06-09 21:34:59 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 6 months ago (2016-06-09 23:44:13 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 23:45:56 UTC) #15
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/9e0f3f0f765bc0625c7988086d8e9ffefd97d337
Cr-Commit-Position: refs/heads/master@{#399051}

Powered by Google App Engine
This is Rietveld 408576698