Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2255543002: Reland of Amends the TypedArray constructor to use the path for primitives for all (Closed)

Created:
4 years, 4 months ago by bakkot
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of Amends the TypedArray constructor to use the path for primitives for all (patchset #1 id:1 of https://codereview.chromium.org/2120763002/ ) Reason for revert: WebGL tests have been updated and rolled (at https://codereview.chromium.org/2227023002), so this should no longer fail outdated tests. Original issue's description: > Revert of Amends the TypedArray constructor to use the path for primitives for all (patchset #4 id:60001 of https://codereview.chromium.org/2096873002/ ) > > Reason for revert: > Speculative revert to unblock roll https://codereview.chromium.org/2114113002/ > > Original issue's description: > > Amends the TypedArray constructor to use the path for primitives for all > > types of primitives, not just undefined, booleans, numbers, and strings. > > (The missing cases were null and Symbol.) This is required by the > > specification, and there are test262 tests which we were failing due to > > this bug. > > > > BUG=v8:5124 > > > > Committed: https://crrev.com/f788bd9cce19815cba746e47bb65abfe25c16208 > > Committed: https://crrev.com/f772c22cd1c492aa0235a8e6012d0386146d2eb2 > > Cr-Original-Commit-Position: refs/heads/master@{#37234} > > Cr-Commit-Position: refs/heads/master@{#37407} > > TBR=littledan@chromium.org,bakkot@google.com > NOTREECHECKS=true > BUG=v8:5124 > > Committed: https://crrev.com/9c0aef52fa672db856ebfac7f4bdcd7d7b103663 > Cr-Commit-Position: refs/heads/master@{#37487} TBR=littledan@chromium.org,hablich@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:5124 Committed: https://crrev.com/95e0ba65ec1d502ca50e2a50d15621accc715206 Cr-Commit-Position: refs/heads/master@{#38691}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -10 lines) Patch
M src/js/typedarray.js View 1 chunk +3 lines, -4 lines 0 comments Download
M test/mjsunit/es6/typedarray.js View 1 chunk +23 lines, -0 lines 0 comments Download
M test/test262/test262.status View 3 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
bakkot
Created Reland of Amends the TypedArray constructor to use the path for primitives for all
4 years, 4 months ago (2016-08-16 19:35:44 UTC) #1
bakkot
PTAL. As with https://codereview.chromium.org/2247073004, I've patched this into Chromium and run the previously failing tests ...
4 years, 4 months ago (2016-08-16 19:49:54 UTC) #4
Dan Ehrenberg
lgtm Looks great, also passes in the blink trybot!
4 years, 4 months ago (2016-08-17 05:07:00 UTC) #7
Dan Ehrenberg
lgtm Thanks a lot for following through with these test fixes.
4 years, 4 months ago (2016-08-17 05:07:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255543002/1
4 years, 4 months ago (2016-08-17 17:41:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 17:44:01 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 17:44:18 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95e0ba65ec1d502ca50e2a50d15621accc715206
Cr-Commit-Position: refs/heads/master@{#38691}

Powered by Google App Engine
This is Rietveld 408576698