Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 2247073004: Reland of Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex. (Closed)

Created:
4 years, 4 months ago by bakkot
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex. (patchset #2 id:170001 of https://codereview.chromium.org/2113593002/ ) Reason for revert: WebGL tests have been updated and rolled (at https://codereview.chromium.org/2227023002), so this should no longer fail outdated tests. Original issue's description: > Revert of Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex. (patchset #8 id:140001 of https://codereview.chromium.org/2090353003/ ) > > Reason for revert: > Speculative revert to unblock roll: https://codereview.chromium.org/2107223003/ > > Original issue's description: > > Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex. > > > > The spec was modified to relax some requirements which implementors had not been > > enforcing. Part of this process involved introducing a new abstract operation > > ToIndex, which had partial overlap with our existing semantics as well as some > > differences (most notably treating undefined as 0). Test262 tests were introduced to > > check for the new semantics, some of which we were failing. This patch amends the > > parts of our implementation corresponding to specification algorithms which use > > ToIndex to follow its semantics precisely. > > > > BUG=v8:4784, v8:5120 > > > > Committed: https://crrev.com/09720349ea058d178521ec58d0a5676443a5a132 > > Cr-Commit-Position: refs/heads/master@{#37406} > > TBR=littledan@chromium.org,adamk@chromium.org,bakkot@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4784, v8:5120 > > Committed: https://crrev.com/b1f7f1f4e41a723d5f997738a07e35a031713b8f > Cr-Commit-Position: refs/heads/master@{#37417} TBR=littledan@chromium.org,adamk@chromium.org,hablich@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:4784, v8:5120 Committed: https://crrev.com/a3c13435aa822041b1fac25baf0e63c56185e4a1 Cr-Commit-Position: refs/heads/master@{#38689}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Correct messages #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -117 lines) Patch
M src/builtins/builtins-dataview.cc View 1 2 chunks +23 lines, -36 lines 0 comments Download
M src/js/runtime.js View 1 2 chunks +8 lines, -0 lines 0 comments Download
M src/js/typedarray.js View 1 2 6 chunks +23 lines, -19 lines 0 comments Download
M src/messages.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M src/objects.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M src/objects.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/dataview-accessors.js View 1 2 chunks +22 lines, -32 lines 0 comments Download
M test/test262/test262.status View 1 2 chunks +14 lines, -28 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
bakkot
Created Reland of Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex.
4 years, 4 months ago (2016-08-16 17:20:07 UTC) #1
bakkot
PTAL. I've patched this into Chromium and run the previously failing test to confirm that ...
4 years, 4 months ago (2016-08-16 19:22:24 UTC) #10
Dan Ehrenberg
lgtm
4 years, 4 months ago (2016-08-17 17:25:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2247073004/190001
4 years, 4 months ago (2016-08-17 17:36:38 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:190001)
4 years, 4 months ago (2016-08-17 17:38:41 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 17:39:05 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a3c13435aa822041b1fac25baf0e63c56185e4a1
Cr-Commit-Position: refs/heads/master@{#38689}

Powered by Google App Engine
This is Rietveld 408576698