Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2227023002:
Roll WebGL 46ec84c..a7fa4b5 and update webgl expectation (Closed)
DescriptionRoll WebGL 46ec84c..a7fa4b5 and update webgl expectation
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/46ec84c..a7fa4b5
BUG=631934, 633022
TEST=bots
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel
Committed: https://crrev.com/dca90d5f9e9939685cb8bc1d82cc07829ed865f0
Cr-Commit-Position: refs/heads/master@{#410865}
Patch Set 1 #Patch Set 2 : update webgl 2 expectation #
Total comments: 1
Messages
Total messages: 29 (20 generated)
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Roll WebGL 46ec84c..a7fa4b5 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/46ec84... BUG= TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel ========== to ========== Roll WebGL 46ec84c..a7fa4b5 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/46ec84... BUG=631934 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel ==========
yunchao.he@intel.com changed reviewers: + jie.a.chen@intel.com, kbr@chromium.org, zmo@chromium.org
Roll in Yizhou's pr for CopyTexSubImage3D to detect feedback loop: https://github.com/KhronosGroup/WebGL/pull/1948, and test that pr against my CL: https://codereview.chromium.org/2190543005/ on all bots. PTAL. Thanks! Unfortunately, Jie's pr for multisampled float point renderbuffer failed on Mac: https://github.com/KhronosGroup/WebGL/pull/1956. So mark it failed on Mac. Jie, could you take a look the failure on Mac?
Description was changed from ========== Roll WebGL 46ec84c..a7fa4b5 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/46ec84... BUG=631934 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel ========== to ========== Roll WebGL 46ec84c..a7fa4b5 and update webgl expectation https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/46ec84... BUG=631934 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Roll WebGL 46ec84c..a7fa4b5 and update webgl expectation https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/46ec84... BUG=631934 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel ========== to ========== Roll WebGL 46ec84c..a7fa4b5 and update webgl expectation https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/46ec84... BUG=631934, 633022 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel ==========
lgtm https://codereview.chromium.org/2227023002/diff/40001/content/test/gpu/gpu_te... File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): https://codereview.chromium.org/2227023002/diff/40001/content/test/gpu/gpu_te... content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:164: ['mac'], bug=633022) This failure expectation is really unfortunate. Please investigate it with high priority. Thanks.
On 2016/08/09 17:38:21, Ken Russell wrote: > lgtm > > https://codereview.chromium.org/2227023002/diff/40001/content/test/gpu/gpu_te... > File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): > > https://codereview.chromium.org/2227023002/diff/40001/content/test/gpu/gpu_te... > content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:164: ['mac'], > bug=633022) > This failure expectation is really unfortunate. Please investigate it with high > priority. Thanks. Got it.
The CQ bit was checked by yunchao.he@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Roll WebGL 46ec84c..a7fa4b5 and update webgl expectation https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/46ec84... BUG=631934, 633022 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel ========== to ========== Roll WebGL 46ec84c..a7fa4b5 and update webgl expectation https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/46ec84... BUG=631934, 633022 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Roll WebGL 46ec84c..a7fa4b5 and update webgl expectation https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/46ec84... BUG=631934, 633022 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel ========== to ========== Roll WebGL 46ec84c..a7fa4b5 and update webgl expectation https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/46ec84... BUG=631934, 633022 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel Committed: https://crrev.com/dca90d5f9e9939685cb8bc1d82cc07829ed865f0 Cr-Commit-Position: refs/heads/master@{#410865} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/dca90d5f9e9939685cb8bc1d82cc07829ed865f0 Cr-Commit-Position: refs/heads/master@{#410865}
Message was sent while issue was closed.
On 2016/08/09 23:10:16, yunchao wrote: > On 2016/08/09 17:38:21, Ken Russell wrote: > > lgtm > > > > > https://codereview.chromium.org/2227023002/diff/40001/content/test/gpu/gpu_te... > > File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): > > > > > https://codereview.chromium.org/2227023002/diff/40001/content/test/gpu/gpu_te... > > content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:164: ['mac'], > > bug=633022) > > This failure expectation is really unfortunate. Please investigate it with > high > > priority. Thanks. > > Got it. All float formats returned NULL array on SAMPLES query. This is not allowed, since gl.R16F, gl.RG16F and gl.R11F_G11F_B10F have to at least support the sample counts less than gl.MAX_SAMPLES according to the spec.
Message was sent while issue was closed.
On 2016/08/11 07:37:02, jchen10 wrote: > On 2016/08/09 23:10:16, yunchao wrote: > > On 2016/08/09 17:38:21, Ken Russell wrote: > > > lgtm > > > > > > > > > https://codereview.chromium.org/2227023002/diff/40001/content/test/gpu/gpu_te... > > > File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): > > > > > > > > > https://codereview.chromium.org/2227023002/diff/40001/content/test/gpu/gpu_te... > > > content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:164: ['mac'], > > > bug=633022) > > > This failure expectation is really unfortunate. Please investigate it with > > high > > > priority. Thanks. > > > > Got it. > > All float formats returned NULL array on SAMPLES query. This is not allowed, > since gl.R16F, gl.RG16F and gl.R11F_G11F_B10F have to at least support the > sample counts less than gl.MAX_SAMPLES according to the spec. Looks like this supression also needs to be added to Linux. Seeing failures on the ATI and Intel bots.
Message was sent while issue was closed.
On 2016/08/11 18:31:36, Geoff Lang wrote: > On 2016/08/11 07:37:02, jchen10 wrote: > > On 2016/08/09 23:10:16, yunchao wrote: > > > On 2016/08/09 17:38:21, Ken Russell wrote: > > > > lgtm > > > > > > > > > > > > > > https://codereview.chromium.org/2227023002/diff/40001/content/test/gpu/gpu_te... > > > > File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py > (right): > > > > > > > > > > > > > > https://codereview.chromium.org/2227023002/diff/40001/content/test/gpu/gpu_te... > > > > content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:164: > ['mac'], > > > > bug=633022) > > > > This failure expectation is really unfortunate. Please investigate it with > > > high > > > > priority. Thanks. > > > > > > Got it. > > > > All float formats returned NULL array on SAMPLES query. This is not allowed, > > since gl.R16F, gl.RG16F and gl.R11F_G11F_B10F have to at least support the > > sample counts less than gl.MAX_SAMPLES according to the spec. > > Looks like this supression also needs to be added to Linux. Seeing failures on > the ATI and Intel bots. On it. |
