Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2255313005: Use MD-ash's auto hide behavior for arc++ windows. (Closed)

Created:
4 years, 4 months ago by oshima
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, sadrul, Peter Beverloo, tfarina, mlamouri+watch-notifications_chromium.org, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, kalyank, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Use MD-ash's auto hide behavior for arc++ windows. This add a runtime flag to enable MD-ash's auto hide behavior , which makes the shelf invisible, for arc++ windows. I'll remove this mode once MD ash is launched. BUG=634566 TEST=covered by unit test. Manually tested on minnie. Committed: https://crrev.com/9913eed0106818160f3828ae7c2fd90dbf985700 Review-Url: https://codereview.chromium.org/2248773002 Cr-Original-Commit-Position: refs/heads/master@{#412309} Cr-Commit-Position: refs/heads/master@{#412352} (cherry picked from commit 41fe96e27f8964dc1c6d9b4e7ffe3ad741b357ef) Register the window in MaximizeModeWindowManager when the window is shown. This is necessary for arc app to set the "don't manage me" flag. BUG=635899 Review-Url: https://codereview.chromium.org/2250963006 Cr-Commit-Position: refs/heads/master@{#412882} (cherry picked from commit 5ef3cfef16fad285e84d8655e592d522401b6ff8) Committed: https://chromium.googlesource.com/chromium/src/+/09b361d92cba6a2e1b78998f74ccda1f0485de39 Committed: https://chromium.googlesource.com/chromium/src/+/6002f379e9052cda4a3573391d79179c95d3c97e

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -3 lines) Patch
M components/exo/shell_surface.cc View 1 2 1 chunk +20 lines, -3 lines 0 comments Download
M components/exo/shell_surface_unittest.cc View 1 2 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
oshima
Committed patchset #2 (id:20001) manually as 09b361d92cba6a2e1b78998f74ccda1f0485de39.
4 years, 4 months ago (2016-08-19 17:42:55 UTC) #2
oshima
4 years, 4 months ago (2016-08-19 17:53:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
6002f379e9052cda4a3573391d79179c95d3c97e.

Powered by Google App Engine
This is Rietveld 408576698