Remove input methods when removing languages

Remove input methods when removing languages

When a user disables a language, we should remove input methods for that
language.

We don't want to remove input methods that *also* support a *different*
enabled language, because those could still be desirable. The bug is that
this check was incorrect, creating false positives where we ought to
remove an input method, but don't.

Options does this correctly. MD Settings has a logical bug: any input method
with more than one *supported* language doesn't get removed when removing the
last *enabled* language that it supports.

The fix is trivial and I added a test that would have caught the bug.

BUG=none
TEST=CrSettingsLanguages
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/749d9ceb83b5c75012e31b0d0c1e3ea7ea8a60f2
Cr-Commit-Position: refs/heads/master@{#412967}

[michaelpg, 2016-08-18 02:01:39]

Description was changed from

==========
Remove input methods when removing languages

When a user disables a language, we should remove input methods for that
language.

We don't want to remove input methods that *also* support a *different*
enabled language, because those could still be desirable. The bug is that
this check was incorrect, creating false positives where we ought to
remove an input method, but don't.

Options does this correctly. MD Settings has a logical bug: any input method
with more than one *supported* language doesn't get removed when removing the
last *enabled* language that it supports.

The fix is trivial and I added a test that would have caught the bug.

BUG=none
TEST=CrSettingsLanguages
==========

to

==========
Remove input methods when removing languages

When a user disables a language, we should remove input methods for that
language.

We don't want to remove input methods that *also* support a *different*
enabled language, because those could still be desirable. The bug is that
this check was incorrect, creating false positives where we ought to
remove an input method, but don't.

Options does this correctly. MD Settings has a logical bug: any input method
with more than one *supported* language doesn't get removed when removing the
last *enabled* language that it supports.

The fix is trivial and I added a test that would have caught the bug.

BUG=none
TEST=CrSettingsLanguages
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-08-18 02:02:12]

Description was changed from

==========
Remove input methods when removing languages

When a user disables a language, we should remove input methods for that
language.

We don't want to remove input methods that *also* support a *different*
enabled language, because those could still be desirable. The bug is that
this check was incorrect, creating false positives where we ought to
remove an input method, but don't.

Options does this correctly. MD Settings has a logical bug: any input method
with more than one *supported* language doesn't get removed when removing the
last *enabled* language that it supports.

The fix is trivial and I added a test that would have caught the bug.

BUG=none
TEST=CrSettingsLanguages
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove input methods when removing languages

When a user disables a language, we should remove input methods for that
language.

We don't want to remove input methods that *also* support a *different*
enabled language, because those could still be desirable. The bug is that
this check was incorrect, creating false positives where we ought to
remove an input method, but don't.

Options does this correctly. MD Settings has a logical bug: any input method
with more than one *supported* language doesn't get removed when removing the
last *enabled* language that it supports.

The fix is trivial and I added a test that would have caught the bug.

BUG=none
TEST=CrSettingsLanguages
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-08-18 02:02:12]

michaelpg@chromium.org changed reviewers:
+ stevenjb@chromium.org

[stevenjb, 2016-08-18 16:05:04]

lgtm

[michaelpg, 2016-08-18 21:45:53]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2016-08-18 21:46:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 23:17:52]

Description was changed from

==========
Remove input methods when removing languages

When a user disables a language, we should remove input methods for that
language.

We don't want to remove input methods that *also* support a *different*
enabled language, because those could still be desirable. The bug is that
this check was incorrect, creating false positives where we ought to
remove an input method, but don't.

Options does this correctly. MD Settings has a logical bug: any input method
with more than one *supported* language doesn't get removed when removing the
last *enabled* language that it supports.

The fix is trivial and I added a test that would have caught the bug.

BUG=none
TEST=CrSettingsLanguages
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove input methods when removing languages

When a user disables a language, we should remove input methods for that
language.

We don't want to remove input methods that *also* support a *different*
enabled language, because those could still be desirable. The bug is that
this check was incorrect, creating false positives where we ought to
remove an input method, but don't.

Options does this correctly. MD Settings has a logical bug: any input method
with more than one *supported* language doesn't get removed when removing the
last *enabled* language that it supports.

The fix is trivial and I added a test that would have caught the bug.

BUG=none
TEST=CrSettingsLanguages
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-08-18 23:17:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-18 23:24:44]

Description was changed from

==========
Remove input methods when removing languages

When a user disables a language, we should remove input methods for that
language.

We don't want to remove input methods that *also* support a *different*
enabled language, because those could still be desirable. The bug is that
this check was incorrect, creating false positives where we ought to
remove an input method, but don't.

Options does this correctly. MD Settings has a logical bug: any input method
with more than one *supported* language doesn't get removed when removing the
last *enabled* language that it supports.

The fix is trivial and I added a test that would have caught the bug.

BUG=none
TEST=CrSettingsLanguages
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove input methods when removing languages

When a user disables a language, we should remove input methods for that
language.

We don't want to remove input methods that *also* support a *different*
enabled language, because those could still be desirable. The bug is that
this check was incorrect, creating false positives where we ought to
remove an input method, but don't.

Options does this correctly. MD Settings has a logical bug: any input method
with more than one *supported* language doesn't get removed when removing the
last *enabled* language that it supports.

The fix is trivial and I added a test that would have caught the bug.

BUG=none
TEST=CrSettingsLanguages
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/749d9ceb83b5c75012e31b0d0c1e3ea7ea8a60f2
Cr-Commit-Position: refs/heads/master@{#412967}
==========

[commit-bot: I haz the power, 2016-08-18 23:24:45]

Patchset 1 (id:??) landed as
https://crrev.com/749d9ceb83b5c75012e31b0d0c1e3ea7ea8a60f2
Cr-Commit-Position: refs/heads/master@{#412967}