Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: chrome/browser/resources/settings/languages_page/languages.js

Issue 2255043002: Remove input methods when removing languages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/fake_language_settings_private.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/languages_page/languages.js
diff --git a/chrome/browser/resources/settings/languages_page/languages.js b/chrome/browser/resources/settings/languages_page/languages.js
index 700d084dd835635eba85a19d05afff683505766d..077ad08d2224fe6cfc59aba5f74bd08baddc35b3 100644
--- a/chrome/browser/resources/settings/languages_page/languages.js
+++ b/chrome/browser/resources/settings/languages_page/languages.js
@@ -488,12 +488,13 @@ SettingsLanguagesSingletonElement = Polymer({
this.deletePrefListItem('spellcheck.dictionaries', languageCode);
if (cr.isChromeOS) {
+ // Remove input methods that don't support any other enabled language.
var inputMethods = this.languageInputMethods_.get(languageCode) || [];
for (var inputMethod of inputMethods) {
var supportsOtherEnabledLanguages = inputMethod.languageCodes.some(
- function(inputMethodLanguageCode) {
- return inputMethodLanguageCode != languageCode &&
- this.isLanguageEnabled(languageCode);
+ function(otherLanguageCode) {
+ return otherLanguageCode != languageCode &&
+ this.isLanguageEnabled(otherLanguageCode);
}.bind(this));
if (!supportsOtherEnabledLanguages)
this.removeInputMethod(inputMethod.id);
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/fake_language_settings_private.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698