Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11012)

Unified Diff: chrome/test/data/webui/settings/languages_page_tests.js

Issue 2255043002: Remove input methods when removing languages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/webui/settings/fake_language_settings_private.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/languages_page_tests.js
diff --git a/chrome/test/data/webui/settings/languages_page_tests.js b/chrome/test/data/webui/settings/languages_page_tests.js
index 8c7ddcc56a9cb1b71732494fe58d8f34797a2985..068aa1239bdca1f0fe8ce8714f2ac8ca4fc3e3c7 100644
--- a/chrome/test/data/webui/settings/languages_page_tests.js
+++ b/chrome/test/data/webui/settings/languages_page_tests.js
@@ -125,14 +125,35 @@ cr.define('settings_languages_page', function() {
test('modifying input methods', function() {
assertEquals(2, languageHelper.languages.inputMethods.enabled.length);
var inputMethods = languageHelper.getInputMethodsForLanguage('en-US');
- assertEquals(2, inputMethods.length);
+ assertEquals(3, inputMethods.length);
+ // We can remove one input method.
var dvorak =
'_comp_ime_fgoepimhcoialccpbmpnnblemnepkkaoxkb:us:dvorak:eng';
languageHelper.removeInputMethod(dvorak);
assertEquals(1, languageHelper.languages.inputMethods.enabled.length);
- // TODO(michaelpg): Test other modifications.
+ // Enable Swahili.
+ languageHelper.enableLanguage('sw');
+ assertEquals(1, languageHelper.languages.inputMethods.enabled.length);
+
+ // Add input methods for Swahili.
+ var sw = '_comp_ime_abcdefghijklmnopqrstuvwxyzabcdefxkb:sw:sw';
+ var swUS = '_comp_ime_abcdefghijklmnopqrstuvwxyzabcdefxkb:us:sw';
+ languageHelper.addInputMethod(sw);
+ languageHelper.addInputMethod(swUS);
+ assertEquals(3, languageHelper.languages.inputMethods.enabled.length);
+
+ // Disable Swahili. The Swahili-only keyboard should be removed.
+ languageHelper.disableLanguage('sw');
+ assertEquals(2, languageHelper.languages.inputMethods.enabled.length);
+
+ // The US Swahili keyboard should still be enabled, because it supports
+ // English which is still enabled.
+ assertTrue(languageHelper.languages.inputMethods.enabled.some(
+ function(inputMethod) {
+ return inputMethod.id == swUS;
+ }));
});
}
});
« no previous file with comments | « chrome/test/data/webui/settings/fake_language_settings_private.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698