Milo: Add task expired as a failure status

Milo: Add task expired as a failure status

BUG=636097
Committed: https://github.com/luci/luci-go/commit/f8c091370435bfe2b8a46551e0c89a7071cc3673

[Ryan Tseng, 2016-08-17 21:34:30]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 21:34:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Tseng, 2016-08-17 21:36:56]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 21:37:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Tseng, 2016-08-17 21:38:36]

Class fix

[Ryan Tseng, 2016-08-17 21:38:37]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 21:38:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Tseng, 2016-08-17 21:44:22]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 21:44:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 21:53:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 21:53:30]

Dry run: This issue passed the CQ dry run.

[Ryan Tseng, 2016-08-30 17:29:08]

hinoka@google.com changed reviewers:
+ dnj@chromium.org

[Ryan Tseng, 2016-08-30 17:29:08]

ptal, milo proto (marzipan? I like marzipan) change, adds "expired" as a top
level status.

[Ryan Tseng, 2016-08-30 21:06:50]

hinoka@google.com changed reviewers:
+ estaab@chromium.org

[Ryan Tseng, 2016-08-30 21:06:50]

+estaab ptal (dnj is ooo these couple days)

[dnj, 2016-09-06 16:46:52]

blarg sorry missed this review. lgtm with the very important comment that I
made.

https://codereview.chromium.org/2254993002/diff/60001/common/proto/milo/annot...
File common/proto/milo/annotations.proto (right):

https://codereview.chromium.org/2254993002/diff/60001/common/proto/milo/annot...
common/proto/milo/annotations.proto:36: EXPIRED = 3;
NO, bad! This protobuf is already in play, and you cannot bump constant values.
Add this at the end after CANCELLED.

[Ryan Tseng, 2016-09-07 20:54:37]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 20:54:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 21:10:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 21:10:44]

Dry run: This issue passed the CQ dry run.

[Ryan Tseng, 2016-09-07 21:45:12]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 21:45:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 21:55:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 21:55:51]

Dry run: This issue passed the CQ dry run.

[Ryan Tseng, 2016-09-07 21:59:58]

Use proto instead

[Ryan Tseng, 2016-09-07 21:59:59]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 22:00:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hinoka, 2016-09-07 22:00:55]

The CQ bit was unchecked by hinoka@chromium.org

[hinoka, 2016-09-07 22:00:58]

The CQ bit was checked by hinoka@chromium.org

[hinoka, 2016-09-07 22:00:59]

The patchset sent to the CQ was uploaded after l-g-t-m from dnj@chromium.org
Link to the patchset: https://codereview.chromium.org/2254993002/#ps120001
(title: "Use proto instead")

[commit-bot: I haz the power, 2016-09-07 22:01:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hinoka, 2016-09-07 22:13:59]

https://codereview.chromium.org/2254993002/diff/60001/common/proto/milo/annot...
File common/proto/milo/annotations.proto (right):

https://codereview.chromium.org/2254993002/diff/60001/common/proto/milo/annot...
common/proto/milo/annotations.proto:36: EXPIRED = 3;
On 2016/09/06 16:46:52, dnj wrote:
> NO, bad! This protobuf is already in play, and you cannot bump constant
values.
> Add this at the end after CANCELLED.

Done.

[commit-bot: I haz the power, 2016-09-07 23:02:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 23:02:17]

Try jobs failed on following builders:
  Luci-go Win Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/311f7bed5632b610)

[hinoka, 2016-09-07 23:03:53]

The CQ bit was checked by hinoka@chromium.org

[commit-bot: I haz the power, 2016-09-07 23:03:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 23:12:35]

Description was changed from

==========
Milo: Add task expired as a failure status

BUG=636097
==========

to

==========
Milo: Add task expired as a failure status

BUG=636097

Committed:
https://github.com/luci/luci-go/commit/f8c091370435bfe2b8a46551e0c89a7071cc3673
==========

[commit-bot: I haz the power, 2016-09-07 23:12:36]

Committed patchset #7 (id:120001) as
https://github.com/luci/luci-go/commit/f8c091370435bfe2b8a46551e0c89a7071cc3673