Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2760)

Unified Diff: milo/api/resp/build.go

Issue 2254993002: Milo: Add task expired as a failure status (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Patch Set: Use proto instead Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/Makefile ('k') | milo/api/resp/status_string.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/api/resp/build.go
diff --git a/milo/api/resp/build.go b/milo/api/resp/build.go
index 0bc1f4345e0700d9c1b6992b5667e512a0425c57..4a23114130583cf262d76e2590e4b356d1ddd5d6 100644
--- a/milo/api/resp/build.go
+++ b/milo/api/resp/build.go
@@ -130,6 +130,9 @@ const (
// InfraFailure if the component has finished incompletely due to a failure in infra.
InfraFailure // A100 Purple
+ // Expired if the component was never scheduled due to resource exhaustion.
+ Expired // A200 Purple
+
// DependencyFailure if the component has finished incompletely due to a failure in a
// dependency.
DependencyFailure // 100 Amber
@@ -142,7 +145,7 @@ const (
// Terminal returns true if the step status won't change.
func (s Status) Terminal() bool {
switch s {
- case Success, Failure, InfraFailure, Warning, DependencyFailure:
+ case Success, Failure, InfraFailure, Warning, DependencyFailure, Expired:
return true
default:
return false
« no previous file with comments | « milo/Makefile ('k') | milo/api/resp/status_string.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698