Milo: Add task expired as a failure status

milo/appengine/logdog/logDogBuild.go

 // Copyright 2016 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package logdog
 
 import (
         "fmt"
         "time"
 
@@ skipping 31 matching lines @@
 
         case miloProto.Status_SUCCESS:
                 comp.Status = resp.Success
 
         case miloProto.Status_FAILURE:
                 if fd := anno.GetFailureDetails(); fd != nil {
                         switch fd.Type {
                         case miloProto.FailureDetails_EXCEPTION, miloProto.FailureDetails_INFRA:
                                 comp.Status = resp.InfraFailure
 
+                        case miloProto.FailureDetails_EXPIRED:
+                                comp.Status = resp.Expired
+
                         case miloProto.FailureDetails_DM_DEPENDENCY_FAILED:
                                 comp.Status = resp.DependencyFailure
 
                         default:
                                 comp.Status = resp.Failure
                         }
 
                         if fd.Text != "" {
                                 comp.Text = append(comp.Text, fd.Text)
                         }
@@ skipping 78 matching lines @@
         }
 
         // This should be the exact same thing.
         comp.Text = append(comp.Text, anno.Text...)
 
         return comp
 }
 
 // AddLogDogToBuild takes a set of logdog streams and populate a milo build.
 // build.Summary.Finished must be set.
-func AddLogDogToBuild(c context.Context, ub URLBuilder, s *Streams, build *resp.MiloBuild) {
-        if s.MainStream == nil {
-                panic("missing main stream")
-        }
-        // Now Fetch the main annotation of the build.
-        var (
-                mainAnno = s.MainStream.Data
-                now      = clock.Now(c)
-        )
+func AddLogDogToBuild(
+        c context.Context, ub URLBuilder, mainAnno *miloProto.Step, build *resp.MiloBuild) {
+        now := clock.Now(c)
 
         // Now fill in each of the step components.
         // TODO(hinoka): This is totes cachable.
         buildCompletedTime := mainAnno.Ended.Time()
         build.Summary = *(miloBuildStep(ub, mainAnno, buildCompletedTime, now))
         for _, substepContainer := range mainAnno.Substep {
                 anno := substepContainer.GetStep()
                 if anno == nil {
                         // TODO: We ignore non-embedded substeps for now.
                         continue
@@ skipping 20 matching lines @@
         for _, prop := range mainAnno.Property {
                 propGroup.Property = append(propGroup.Property, &resp.Property{
                         Key:   prop.Name,
                         Value: prop.Value,
                 })
         }
         build.PropertyGroup = append(build.PropertyGroup, propGroup)
 
         return
 }