Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3058)

Unified Diff: cc/output/overlay_unittest.cc

Issue 2254543003: cc: Delete the RendererClient class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@setvisible-browser
Patch Set: deleterendererclient: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/gl_renderer_unittest.cc ('k') | cc/output/renderer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/overlay_unittest.cc
diff --git a/cc/output/overlay_unittest.cc b/cc/output/overlay_unittest.cc
index a26d8a023e8b46d524a21e636f342de1057fd33d..d31cb7a33b33e382f094d520d114ad037ea7f3e7 100644
--- a/cc/output/overlay_unittest.cc
+++ b/cc/output/overlay_unittest.cc
@@ -1234,16 +1234,10 @@ TEST_F(CALayerOverlayTest, SkipTransparent) {
class OverlayInfoRendererGL : public GLRenderer {
public:
- OverlayInfoRendererGL(RendererClient* client,
- const RendererSettings* settings,
+ OverlayInfoRendererGL(const RendererSettings* settings,
OutputSurface* output_surface,
ResourceProvider* resource_provider)
- : GLRenderer(client,
- settings,
- output_surface,
- resource_provider,
- NULL,
- 0),
+ : GLRenderer(settings, output_surface, resource_provider, NULL, 0),
expect_overlays_(false) {}
MOCK_METHOD3(DoDrawQuad,
@@ -1273,12 +1267,6 @@ class OverlayInfoRendererGL : public GLRenderer {
bool expect_overlays_;
};
-class FakeRendererClient : public RendererClient {
- public:
- // RendererClient methods.
- void SetFullRootLayerDamage() override {}
-};
-
class MockOverlayScheduler {
public:
MOCK_METHOD5(Schedule,
@@ -1307,8 +1295,7 @@ class GLRendererWithOverlaysTest : public testing::Test {
output_surface_->SetOverlayCandidateValidator(new SingleOverlayValidator);
renderer_ = base::WrapUnique(new OverlayInfoRendererGL(
- &renderer_client_, &settings_, output_surface_.get(),
- resource_provider_.get()));
+ &settings_, output_surface_.get(), resource_provider_.get()));
renderer_->SetVisible(true);
}
@@ -1341,7 +1328,6 @@ class GLRendererWithOverlaysTest : public testing::Test {
RendererSettings settings_;
FakeOutputSurfaceClient output_surface_client_;
std::unique_ptr<OverlayOutputSurface> output_surface_;
- FakeRendererClient renderer_client_;
std::unique_ptr<ResourceProvider> resource_provider_;
std::unique_ptr<OverlayInfoRendererGL> renderer_;
scoped_refptr<TestContextProvider> provider_;
« no previous file with comments | « cc/output/gl_renderer_unittest.cc ('k') | cc/output/renderer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698