Prompt for CVC in credit card assist.

Prompt for CVC in credit card assist.

BUG=630656
Committed: https://crrev.com/e88a650a960017660d951f925129a492c61619f8
Cr-Commit-Position: refs/heads/master@{#415151}

[please use gerrit instead, 2016-08-19 00:05:38]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 00:06:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-08-19 00:08:18]

rouslan@chromium.org changed reviewers:
+ rogerm@chromium.org

[please use gerrit instead, 2016-08-19 00:08:19]

Roger, ptal. Video in
https://bugs.chromium.org/p/chromium/issues/attachment?aid=247491

[commit-bot: I haz the power, 2016-08-19 00:32:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 00:32:58]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Roger McFarlane (Chromium), 2016-08-19 15:25:50]

Looks good except for the Android and iOS bot failures.

[Roger McFarlane (Chromium), 2016-08-19 15:26:21]

rogerm@chromium.org changed reviewers:
+ sebsg@chromium.org

[Roger McFarlane (Chromium), 2016-08-19 15:26:22]

+sebsg

[please use gerrit instead, 2016-08-19 21:46:10]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 21:47:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-08-20 00:00:12]

Ptal patch 2.

[commit-bot: I haz the power, 2016-08-20 00:29:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 00:29:15]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[sebsg, 2016-08-22 13:49:41]

LGTM! Thanks for making this.

[please use gerrit instead, 2016-08-22 16:28:26]

rouslan@chromium.org changed reviewers:
+ estade@chromium.org

[please use gerrit instead, 2016-08-22 16:28:26]

Evan, owners ptal.

[Evan Stade, 2016-08-26 22:26:01]

lgtm

https://codereview.chromium.org/2254353002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_assistant.h (right):

https://codereview.chromium.org/2254353002/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_assistant.h:47: void
OnFullCardDetails(const CreditCard& card,
nit: OnFooBar doesn't make much sense when FooBar doesn't contain a verb

[please use gerrit instead, 2016-08-26 23:27:51]

https://codereview.chromium.org/2254353002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_assistant.h (right):

https://codereview.chromium.org/2254353002/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_assistant.h:47: void
OnFullCardDetails(const CreditCard& card,
On 2016/08/26 22:26:01, Evan Stade (ooo wed-thurs) wrote:
> nit: OnFooBar doesn't make much sense when FooBar doesn't contain a verb

How about OnFullCardResponse or OnFullCardResponded? I prefer the former,
because it mirrors OnFullCardError.

[Evan Stade, 2016-08-26 23:39:34]

On 2016/08/26 23:27:51, rouslan wrote:
>
https://codereview.chromium.org/2254353002/diff/20001/components/autofill/cor...
> File components/autofill/core/browser/autofill_assistant.h (right):
> 
>
https://codereview.chromium.org/2254353002/diff/20001/components/autofill/cor...
> components/autofill/core/browser/autofill_assistant.h:47: void
> OnFullCardDetails(const CreditCard& card,
> On 2016/08/26 22:26:01, Evan Stade (ooo wed-thurs) wrote:
> > nit: OnFooBar doesn't make much sense when FooBar doesn't contain a verb
> 
> How about OnFullCardResponse or OnFullCardResponded? I prefer the former,
> because it mirrors OnFullCardError.

OnFullCardError suffers from the same problem. Error is not a verb.

[please use gerrit instead, 2016-08-27 01:21:16]

On 2016/08/26 23:39:34, Evan Stade (ooo wed-thurs) wrote:
> On 2016/08/26 23:27:51, rouslan wrote:
> >
>
https://codereview.chromium.org/2254353002/diff/20001/components/autofill/cor...
> > File components/autofill/core/browser/autofill_assistant.h (right):
> > 
> >
>
https://codereview.chromium.org/2254353002/diff/20001/components/autofill/cor...
> > components/autofill/core/browser/autofill_assistant.h:47: void
> > OnFullCardDetails(const CreditCard& card,
> > On 2016/08/26 22:26:01, Evan Stade (ooo wed-thurs) wrote:
> > > nit: OnFooBar doesn't make much sense when FooBar doesn't contain a verb
> > 
> > How about OnFullCardResponse or OnFullCardResponded? I prefer the former,
> > because it mirrors OnFullCardError.
> 
> OnFullCardError suffers from the same problem. Error is not a verb.

How about OnFullCardResponded and OnFullCardCancelled?

[Evan Stade, 2016-08-27 01:52:35]

On 2016/08/27 01:21:16, rouslan wrote:
> On 2016/08/26 23:39:34, Evan Stade (ooo wed-thurs) wrote:
> > On 2016/08/26 23:27:51, rouslan wrote:
> > >
> >
>
https://codereview.chromium.org/2254353002/diff/20001/components/autofill/cor...
> > > File components/autofill/core/browser/autofill_assistant.h (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2254353002/diff/20001/components/autofill/cor...
> > > components/autofill/core/browser/autofill_assistant.h:47: void
> > > OnFullCardDetails(const CreditCard& card,
> > > On 2016/08/26 22:26:01, Evan Stade (ooo wed-thurs) wrote:
> > > > nit: OnFooBar doesn't make much sense when FooBar doesn't contain a verb
> > > 
> > > How about OnFullCardResponse or OnFullCardResponded? I prefer the former,
> > > because it mirrors OnFullCardError.
> > 
> > OnFullCardError suffers from the same problem. Error is not a verb.
> 
> How about OnFullCardResponded and OnFullCardCancelled?

Wait, is it an error or the user cancelling the dialog? That's a pretty big
distinction. I was going to suggest
OnFullCardRequestSucceeded/Failed or OnGotFullCardDetails or something but now
I'm not sure I even understand what these methods are for.

[please use gerrit instead, 2016-08-27 03:11:33]

On 2016/08/27 01:52:35, Evan Stade (ooo wed-thurs) wrote:
> Wait, is it an error or the user cancelling the dialog? That's a pretty big
> distinction. I was going to suggest
> OnFullCardRequestSucceeded/Failed or OnGotFullCardDetails or something but now
> I'm not sure I even understand what these methods are for.

User is cancelling the CVC unmask dialog either because they felt like it or
because they have encountered an unrecoverable error, e.g., servers unreachable.
The rest of the software does not really care why the user is closing the CVC
unmask dialog. The point is that full card details (card #, expiration, and cvc)
were not acquired.

I will go with OnFullCardRequestSucceeded/Failed.

[please use gerrit instead, 2016-08-29 17:32:56]

Renamed in patch 3. Sending to cq.

[please use gerrit instead, 2016-08-29 17:33:03]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-08-29 17:33:03]

The patchset sent to the CQ was uploaded after l-g-t-m from sebsg@chromium.org,
estade@chromium.org
Link to the patchset: https://codereview.chromium.org/2254353002/#ps40001
(title: "Better callback names")

[commit-bot: I haz the power, 2016-08-29 17:50:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 05:24:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-30 05:26:41]

Description was changed from

==========
Prompt for CVC in credit card assist.

BUG=630656
==========

to

==========
Prompt for CVC in credit card assist.

BUG=630656

Committed: https://crrev.com/e88a650a960017660d951f925129a492c61619f8
Cr-Commit-Position: refs/heads/master@{#415151}
==========

[commit-bot: I haz the power, 2016-08-30 05:26:43]

Patchset 3 (id:??) landed as
https://crrev.com/e88a650a960017660d951f925129a492c61619f8
Cr-Commit-Position: refs/heads/master@{#415151}