Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: components/autofill/core/browser/payments/full_card_request.cc

Issue 2254353002: Prompt for CVC in credit card assist. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Better callback names Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/payments/full_card_request.cc
diff --git a/components/autofill/core/browser/payments/full_card_request.cc b/components/autofill/core/browser/payments/full_card_request.cc
index d16715ee713217956ce61887f90e0c246b679531..f2f63805e588f8e190a5cfd61e5972dc491ecc03 100644
--- a/components/autofill/core/browser/payments/full_card_request.cc
+++ b/components/autofill/core/browser/payments/full_card_request.cc
@@ -41,7 +41,7 @@ void FullCardRequest::GetFullCard(const CreditCard& card,
// already set, then immediately reject the new request through the method
// parameter |delegate|.
if (delegate_) {
- delegate->OnFullCardError();
+ delegate->OnFullCardRequestFailed();
return;
}
@@ -83,7 +83,7 @@ void FullCardRequest::OnUnmaskResponse(const UnmaskResponse& response) {
if (!should_unmask_card_) {
if (delegate_)
- delegate_->OnFullCardDetails(request_->card, response.cvc);
+ delegate_->OnFullCardRequestSucceeded(request_->card, response.cvc);
Reset();
autofill_client_->OnUnmaskVerificationResult(AutofillClient::SUCCESS);
return;
@@ -98,7 +98,7 @@ void FullCardRequest::OnUnmaskResponse(const UnmaskResponse& response) {
void FullCardRequest::OnUnmaskPromptClosed() {
if (delegate_)
- delegate_->OnFullCardError();
+ delegate_->OnFullCardRequestFailed();
Reset();
}
@@ -126,7 +126,7 @@ void FullCardRequest::OnDidGetRealPan(AutofillClient::PaymentsRpcResult result,
// Intentional fall through.
case AutofillClient::NETWORK_ERROR: {
if (delegate_)
- delegate_->OnFullCardError();
+ delegate_->OnFullCardRequestFailed();
Reset();
break;
}
@@ -141,8 +141,8 @@ void FullCardRequest::OnDidGetRealPan(AutofillClient::PaymentsRpcResult result,
personal_data_manager_->UpdateServerCreditCard(request_->card);
if (delegate_)
- delegate_->OnFullCardDetails(request_->card,
- request_->user_response.cvc);
+ delegate_->OnFullCardRequestSucceeded(request_->card,
+ request_->user_response.cvc);
Reset();
break;
}

Powered by Google App Engine
This is Rietveld 408576698