Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: chrome/browser/autofill/android/personal_data_manager_android.cc

Issue 2254353002: Prompt for CVC in credit card assist. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Better callback names Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_assistant.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/android/personal_data_manager_android.cc
diff --git a/chrome/browser/autofill/android/personal_data_manager_android.cc b/chrome/browser/autofill/android/personal_data_manager_android.cc
index 008a475e863171be6830436757d1c05e8e73a41f..6f9f5f821607519a124d3889e47b5aea12dfe84c 100644
--- a/chrome/browser/autofill/android/personal_data_manager_android.cc
+++ b/chrome/browser/autofill/android/personal_data_manager_android.cc
@@ -248,28 +248,28 @@ class FullCardRequester : public payments::FullCardRequest::Delegate,
jdelegate_.Reset(env, jdelegate);
if (!card_) {
- OnFullCardError();
+ OnFullCardRequestFailed();
return;
}
content::WebContents* contents =
content::WebContents::FromJavaWebContents(jweb_contents);
if (!contents) {
- OnFullCardError();
+ OnFullCardRequestFailed();
return;
}
ContentAutofillDriverFactory* factory =
ContentAutofillDriverFactory::FromWebContents(contents);
if (!factory) {
- OnFullCardError();
+ OnFullCardRequestFailed();
return;
}
ContentAutofillDriver* driver =
factory->DriverForFrame(contents->GetMainFrame());
if (!driver) {
- OnFullCardError();
+ OnFullCardRequestFailed();
return;
}
@@ -281,8 +281,8 @@ class FullCardRequester : public payments::FullCardRequest::Delegate,
virtual ~FullCardRequester() {}
// payments::FullCardRequest::Delegate:
- void OnFullCardDetails(const CreditCard& card,
- const base::string16& cvc) override {
+ void OnFullCardRequestSucceeded(const CreditCard& card,
+ const base::string16& cvc) override {
JNIEnv* env = base::android::AttachCurrentThread();
Java_FullCardRequestDelegate_onFullCardDetails(
env, jdelegate_, CreateJavaCreditCardFromNative(env, card),
@@ -291,7 +291,7 @@ class FullCardRequester : public payments::FullCardRequest::Delegate,
}
// payments::FullCardRequest::Delegate:
- void OnFullCardError() override {
+ void OnFullCardRequestFailed() override {
JNIEnv* env = base::android::AttachCurrentThread();
Java_FullCardRequestDelegate_onFullCardError(env, jdelegate_);
delete this;
@@ -461,7 +461,6 @@ ScopedJavaLocalRef<jstring> PersonalDataManagerAndroid::SetCreditCard(
return ConvertUTF8ToJavaString(env, card.guid());
}
-
void PersonalDataManagerAndroid::UpdateServerCardBillingAddress(
JNIEnv* env,
const JavaParamRef<jobject>& unused_obj,
@@ -621,7 +620,7 @@ jint PersonalDataManagerAndroid::GetCreditCardUseCountForTesting(
jlong PersonalDataManagerAndroid::GetCreditCardUseDateForTesting(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& unused_obj,
- const base::android::JavaParamRef<jstring>& jguid){
+ const base::android::JavaParamRef<jstring>& jguid) {
CreditCard* card = personal_data_manager_->GetCreditCardByGUID(
ConvertJavaStringToUTF8(env, jguid));
return card->use_date().ToTimeT();
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_assistant.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698