Issue 225413016: win: sealed -> final rename, part 3/3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 225413016: win: sealed -> final rename, part 3/3. (Closed)

Created:
6 years, 8 months ago by Nico

Modified:
6 years, 8 months ago

Reviewers:
scottmg

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

win: sealed -> final rename, part 3/3. Part 1: https://codereview.chromium.org/224763005 Part 2: https://codereview.chromium.org/224833004 BUG=none R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262146

Patch Set 2 : overridetoo #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -9 lines)			Patch
	M	base/compiler_specific.h	View	1	2 chunks	+2 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

https://codereview.chromium.org/225413016/diff/1/base/compiler_specific.h File base/compiler_specific.h (right): https://codereview.chromium.org/225413016/diff/1/base/compiler_specific.h#newcode157 base/compiler_specific.h:157: #if defined(__clang__) || defined(COMPILER_MSVC) (I tried adding the gcc ...

6 years, 8 months ago (2014-04-07 16:44:03 UTC) #1

Nico

6 years, 8 months ago (2014-04-07 17:28:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r262146 (presubmit successful).

Expand Messages | Collapse Messages

Issue 225413016: win: sealed -> final rename, part 3/3. (Closed)

Description

Patch Set 1 #

Patch Set 2 : overridetoo #

Messages