win: Now that we're on msvs2013, spell final 'final' not 'sealed'.

win: Now that we're on msvs2013, spell final 'final' not 'sealed'.

BUG=none
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261658

[scottmg, 2014-04-04 00:30:04]

lgtm

https://codereview.chromium.org/224763005/diff/1/base/compiler_specific.h
File base/compiler_specific.h (right):

https://codereview.chromium.org/224763005/diff/1/base/compiler_specific.h#new...
base/compiler_specific.h:159: #elif defined(COMPILER_GCC) && __cplusplus >=
201103 && \
guess you could merge all this too, but maybe it's harder to read

[Nico, 2014-04-04 00:48:15]

Best tryjob failure:

FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma\gomacc.exe
"E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo
/showIncludes /FC
@obj\third_party\WebKit\Source\platform\testing\blink_platform_run_all_tests.RunAllTests.obj.rsp
/c ..\..\third_party\WebKit\Source\platform\testing\RunAllTests.cpp
/Foobj\third_party\WebKit\Source\platform\testing\blink_platform_run_all_tests.RunAllTests.obj
/Fdobj\third_party\WebKit\Source\platform\blink_platform_run_all_tests.cc.pdb 
e:\b\build\slave\win\build\src\base\compiler_specific.h(158) : error C2220:
warning treated as error - no 'object' file generated
e:\b\build\slave\win\build\src\base\compiler_specific.h(158) : warning C4005:
'FINAL' : macro redefinition
       
e:\b\build\slave\win\build\src\third_party\webkit\source\wtf\compiler.h(214) :
see previous definition of 'FINAL'


:'-(

[scottmg, 2014-04-04 01:16:18]

Ah, I ran into that in a different context; if the macros are textually
identical it doesn't emit that warning, so you "just" need to change both
sides at exactly the same time. :)


On Thu, Apr 3, 2014 at 5:48 PM, <thakis@chromium.org> wrote:

> Best tryjob failure:
>
> FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma\gomacc.exe
> "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe"
> /nologo
> /showIncludes /FC
> @obj\third_party\WebKit\Source\platform\testing\blink_
> platform_run_all_tests.RunAllTests.obj.rsp
> /c ..\..\third_party\WebKit\Source\platform\testing\RunAllTests.cpp
> /Foobj\third_party\WebKit\Source\platform\testing\blink_
> platform_run_all_tests.RunAllTests.obj
> /Fdobj\third_party\WebKit\Source\platform\blink_
> platform_run_all_tests.cc.pdb
> e:\b\build\slave\win\build\src\base\compiler_specific.h(158) : error
> C2220:
> warning treated as error - no 'object' file generated
> e:\b\build\slave\win\build\src\base\compiler_specific.h(158) : warning
> C4005:
> 'FINAL' : macro redefinition
>
> e:\b\build\slave\win\build\src\third_party\webkit\source\wtf\compiler.h(214)
> :
> see previous definition of 'FINAL'
>
>
> :'-(
>
> https://codereview.chromium.org/224763005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2014-04-04 01:22:30]

ima land https://codereview.chromium.org/224813004 first (assuming it
compiles), then this, then remove the #undefs


On Thu, Apr 3, 2014 at 6:16 PM, Scott Graham <scottmg@chromium.org> wrote:

> Ah, I ran into that in a different context; if the macros are textually
> identical it doesn't emit that warning, so you "just" need to change both
> sides at exactly the same time. :)
>
>
> On Thu, Apr 3, 2014 at 5:48 PM, <thakis@chromium.org> wrote:
>
>> Best tryjob failure:
>>
>> FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma\gomacc.exe
>> "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe"
>> /nologo
>> /showIncludes /FC
>> @obj\third_party\WebKit\Source\platform\testing\blink_
>> platform_run_all_tests.RunAllTests.obj.rsp
>> /c ..\..\third_party\WebKit\Source\platform\testing\RunAllTests.cpp
>> /Foobj\third_party\WebKit\Source\platform\testing\blink_
>> platform_run_all_tests.RunAllTests.obj
>> /Fdobj\third_party\WebKit\Source\platform\blink_
>> platform_run_all_tests.cc.pdb
>> e:\b\build\slave\win\build\src\base\compiler_specific.h(158) : error
>> C2220:
>> warning treated as error - no 'object' file generated
>> e:\b\build\slave\win\build\src\base\compiler_specific.h(158) : warning
>> C4005:
>> 'FINAL' : macro redefinition
>>
>> e:\b\build\slave\win\build\src\third_party\webkit\source\wtf\compiler.h(214)
>> :
>> see previous definition of 'FINAL'
>>
>>
>> :'-(
>>
>> https://codereview.chromium.org/224763005/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2014-04-04 02:39:13]

Hm, that didn't work. Instead, giving patch set 2 of this review a try, which
seems to do the trick.

[Nico, 2014-04-04 02:39:18]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-04-04 02:39:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/224763005/20001

[commit-bot: I haz the power, 2014-04-04 03:54:40]

Change committed as 261658