Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 224833004: win: Now that we're on msvs2013, spell final 'final' not 'sealed'. (Closed)

Created:
6 years, 8 months ago by Nico
Modified:
6 years, 8 months ago
CC:
blink-reviews, Mikhail, adamk+blink_chromium.org, Inactive, abarth-chromium
Visibility:
Public.

Description

win: Now that we're on msvs2013, spell final 'final' not 'sealed'. Part 2 of 3. Part 1: https://codereview.chromium.org/224763005/ BUG=none NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170868

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M Source/wtf/Compiler.h View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Nico
6 years, 8 months ago (2014-04-04 04:56:19 UTC) #1
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 8 months ago (2014-04-04 04:56:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/224833004/1
6 years, 8 months ago (2014-04-04 04:56:34 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-04 05:16:07 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-04 05:16:07 UTC) #5
jochen (gone - plz use gerrit)
lgtm
6 years, 8 months ago (2014-04-04 08:58:11 UTC) #6
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 8 months ago (2014-04-04 13:35:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/224833004/1
6 years, 8 months ago (2014-04-04 13:35:09 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-04 13:35:31 UTC) #9
Message was sent while issue was closed.
Change committed as 170868

Powered by Google App Engine
This is Rietveld 408576698