Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2253523002: Merge TextCheckingHelper into SpellChecker Part 2 (Closed)

Created:
4 years, 4 months ago by Xiaocheng
Modified:
4 years, 4 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@EliminateTextCheckingHelper
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge TextCheckingHelper into SpellChecker Part 2 This patch moves the implementation of SpellChecker::findFirstMisspellingOrBadGrammar() and SpellChecker::findMisspellings() from TextCheckingHelper.cpp to SpellChecker.cpp without any other modification. Followup patches will clean up the code. Previous patches: - Part 1: crrev.com/2246053003 BUG=619452 TEST=n/a; no behavior change Committed: https://crrev.com/b3454acb3a76f88452bbfddabb7b3d13e112859b Cr-Commit-Position: refs/heads/master@{#412209}

Patch Set 1 #

Patch Set 2 : Fix compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -110 lines) Patch
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 1 2 chunks +109 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.cpp View 2 chunks +0 lines, -110 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 18 (13 generated)
Xiaocheng
PTAL.
4 years, 4 months ago (2016-08-16 08:38:59 UTC) #5
yosin_UTC9
lgtm
4 years, 4 months ago (2016-08-16 08:50:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2253523002/20001
4 years, 4 months ago (2016-08-16 10:41:26 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-16 10:45:01 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 10:46:13 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b3454acb3a76f88452bbfddabb7b3d13e112859b
Cr-Commit-Position: refs/heads/master@{#412209}

Powered by Google App Engine
This is Rietveld 408576698