Merge TextCheckingHelper into SpellChecker Part 1

Merge TextCheckingHelper into SpellChecker Part 1

Class TextCheckingHelper should be eliminated and merged into SpellChecker
because it is only used by SpellChecker::advanceToNextMisspelling() and does
not implement complicated logic.

This patch removes the class and changes its member functions into members
of SpellChecker. Followup patches will move the functions to SpellChecker.cpp
and cleanup the code.

BUG=619452
TEST=n/a; no behavior change

Committed: https://crrev.com/94e34bbf30308de2f40faedccb857766835c6ab2
Cr-Commit-Position: refs/heads/master@{#412200}

[Xiaocheng, 2016-08-16 08:14:47]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 08:14:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-08-16 08:18:08]

Description was changed from

==========
Merge TextCheckingHelper into SpellChecker Part 1

BUG=
==========

to

==========
Merge TextCheckingHelper into SpellChecker Part 1

Class TextCheckingHelper should be eliminated and merged into SpellChecker
because it is only used by SpellChecker::advanceToNextMisspelling() and does
not implement complicated logic.

This patch removes the class and changes its member functions into members
of SpellChecker. Followup patches will move the functions to SpellChecker.cpp
and cleanup the code.

BUG=619452
TEST=n/a; no behavior change
==========

[Xiaocheng, 2016-08-16 08:18:20]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-08-16 08:18:20]

PTAL?

[yosin_UTC9, 2016-08-16 08:30:33]

lgtm w/ nit

Don't forget to have TODO for moving.

https://codereview.chromium.org/2246053003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.cpp
(right):

https://codereview.chromium.org/2246053003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.cpp:45:
void SpellChecker::findMisspellings(const String& text,
Vector<TextCheckingResult>& results)
Please add TODO comment that this function should be moved to "SpellChecker.cpp"
to prevent people who see this file before committing following patches, to be
surprised.

[Xiaocheng, 2016-08-16 08:32:24]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2016-08-16 08:32:25]

https://codereview.chromium.org/2246053003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.cpp
(right):

https://codereview.chromium.org/2246053003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.cpp:45:
void SpellChecker::findMisspellings(const String& text,
Vector<TextCheckingResult>& results)
On 2016/08/16 at 08:30:32, Yosi_UTC9 wrote:
> Please add TODO comment that this function should be moved to
"SpellChecker.cpp"
> to prevent people who see this file before committing following patches, to be
surprised.

Whoops, done.

[Xiaocheng, 2016-08-16 08:32:25]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2246053003/#ps20001
(title: "Add TODOs")

[commit-bot: I haz the power, 2016-08-16 08:32:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 09:46:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-16 09:47:51]

Description was changed from

==========
Merge TextCheckingHelper into SpellChecker Part 1

Class TextCheckingHelper should be eliminated and merged into SpellChecker
because it is only used by SpellChecker::advanceToNextMisspelling() and does
not implement complicated logic.

This patch removes the class and changes its member functions into members
of SpellChecker. Followup patches will move the functions to SpellChecker.cpp
and cleanup the code.

BUG=619452
TEST=n/a; no behavior change
==========

to

==========
Merge TextCheckingHelper into SpellChecker Part 1

Class TextCheckingHelper should be eliminated and merged into SpellChecker
because it is only used by SpellChecker::advanceToNextMisspelling() and does
not implement complicated logic.

This patch removes the class and changes its member functions into members
of SpellChecker. Followup patches will move the functions to SpellChecker.cpp
and cleanup the code.

BUG=619452
TEST=n/a; no behavior change

Committed: https://crrev.com/94e34bbf30308de2f40faedccb857766835c6ab2
Cr-Commit-Position: refs/heads/master@{#412200}
==========

[commit-bot: I haz the power, 2016-08-16 09:47:51]

Patchset 2 (id:??) landed as
https://crrev.com/94e34bbf30308de2f40faedccb857766835c6ab2
Cr-Commit-Position: refs/heads/master@{#412200}