Merge TextCheckingHelper into SpellChecker Part 3

Merge TextCheckingHelper into SpellChecker Part 3

This patch does code cleanup in SpellChecker.h/cpp after moving code
from TextCheckingHelper. Cleanup to TextCheckingHelper.h/cpp will be
done in followup patches.

Previous patches:
- Part 1: http://crrev.com/2246053003
- Part 2: http://crrev.com/2253523002

BUG=619452
TEST=n/a; no behavior change

Committed: https://crrev.com/85313d07c90a0ff9a229646aad87ecf6cee13a38
Cr-Commit-Position: refs/heads/master@{#412422}

[Xiaocheng, 2016-08-16 09:11:52]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 09:12:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-08-16 09:13:30]

Description was changed from

==========
Merge TextCheckingHelper into SpellChecker Part 3

This patch renames TextCheckingHelper.h/cpp to TextCheckingParagraph.c/cpp
since there is no longer TextCheckingHelper. This patch also does code
cleanup in SpellChecker.h/cpp and TextCheckingParagraph.h/cpp after moving
code in the previous patches.

BUG=
==========

to

==========
Merge TextCheckingHelper into SpellChecker Part 3

This patch renames TextCheckingHelper.h/cpp to TextCheckingParagraph.c/cpp
since there is no longer TextCheckingHelper. This patch also does code
cleanup in SpellChecker.h/cpp and TextCheckingParagraph.h/cpp after moving
code in the previous patches.

This is the final patch for merging TextCheckingHelper into SpellChecker.

BUG=619452
TEST=n/a; no behavior change
==========

[Xiaocheng, 2016-08-16 09:13:30]

xiaochengh@chromium.org changed reviewers:
+ tkent@chromium.org, yosin@chromium.org

[Xiaocheng, 2016-08-16 09:14:30]

PTAL.

[yosin_UTC9, 2016-08-16 09:18:29]

Could you split this patch into two?
 1. Re-factor SpellChecker::findMissspelling()
 2. Rename TextCheckingHelper.{cpp,h} to TextCheckingParagraph.{cpp,h}
Since they are independent.

[Xiaocheng, 2016-08-16 09:24:30]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 09:24:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-08-16 09:25:41]

Description was changed from

==========
Merge TextCheckingHelper into SpellChecker Part 3

This patch renames TextCheckingHelper.h/cpp to TextCheckingParagraph.c/cpp
since there is no longer TextCheckingHelper. This patch also does code
cleanup in SpellChecker.h/cpp and TextCheckingParagraph.h/cpp after moving
code in the previous patches.

This is the final patch for merging TextCheckingHelper into SpellChecker.

BUG=619452
TEST=n/a; no behavior change
==========

to

==========
Merge TextCheckingHelper into SpellChecker Part 3

This patch does code cleanup in SpellChecker.h/cpp and
TextCheckingHelper.h/cpp after moving code in the previous patches.

A followup patch will rename TextCheckingHelper.h/cpp to
TextCheckingParagraph.c/cpp since there is no longer TextCheckingHelper.

BUG=619452
TEST=n/a; no behavior change
==========

[Xiaocheng, 2016-08-16 09:26:11]

On 2016/08/16 at 09:18:29, yosin wrote:
> Could you split this patch into two?
>  1. Re-factor SpellChecker::findMissspelling()
>  2. Rename TextCheckingHelper.{cpp,h} to TextCheckingParagraph.{cpp,h}
> Since they are independent.

OK. This patch only does refactoring now. Renaming will be left to the last
patch.

[yosin_UTC9, 2016-08-16 09:34:15]

Please refer with CL number for "previous patch".

https://codereview.chromium.org/2247273002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.h
(right):

https://codereview.chromium.org/2247273002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.h:25:
#include "core/editing/Position.h"
Oops, changes of "TextCheckingHelper.{cpp.h}" are independent from
"SpellChecker.{cpp.h}".
Could you move "TextCheckingHelper.{cpp.h}" to another patch?

[commit-bot: I haz the power, 2016-08-16 10:29:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 10:29:25]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xiaocheng, 2016-08-16 10:47:09]

Description was changed from

==========
Merge TextCheckingHelper into SpellChecker Part 3

This patch does code cleanup in SpellChecker.h/cpp and
TextCheckingHelper.h/cpp after moving code in the previous patches.

A followup patch will rename TextCheckingHelper.h/cpp to
TextCheckingParagraph.c/cpp since there is no longer TextCheckingHelper.

BUG=619452
TEST=n/a; no behavior change
==========

to

==========
Merge TextCheckingHelper into SpellChecker Part 3

This patch does code cleanup in SpellChecker.h/cpp after moving code
from TextCheckingHelper. Cleanup to TextCheckingHelper.h/cpp will be
done in followup patches.

Previous patches:
- Part 1: http://crrev.com/2246053003
- Part 2: http://crrev.com/2253523002


BUG=619452
TEST=n/a; no behavior change
==========

[Xiaocheng, 2016-08-16 10:47:43]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 10:47:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 12:15:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 12:15:36]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-08-17 02:05:02]

lgtm

[Xiaocheng, 2016-08-17 02:09:12]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2016-08-17 02:09:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 02:13:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-17 02:15:32]

Description was changed from

==========
Merge TextCheckingHelper into SpellChecker Part 3

This patch does code cleanup in SpellChecker.h/cpp after moving code
from TextCheckingHelper. Cleanup to TextCheckingHelper.h/cpp will be
done in followup patches.

Previous patches:
- Part 1: http://crrev.com/2246053003
- Part 2: http://crrev.com/2253523002


BUG=619452
TEST=n/a; no behavior change
==========

to

==========
Merge TextCheckingHelper into SpellChecker Part 3

This patch does code cleanup in SpellChecker.h/cpp after moving code
from TextCheckingHelper. Cleanup to TextCheckingHelper.h/cpp will be
done in followup patches.

Previous patches:
- Part 1: http://crrev.com/2246053003
- Part 2: http://crrev.com/2253523002

BUG=619452
TEST=n/a; no behavior change

Committed: https://crrev.com/85313d07c90a0ff9a229646aad87ecf6cee13a38
Cr-Commit-Position: refs/heads/master@{#412422}
==========

[commit-bot: I haz the power, 2016-08-17 02:15:33]

Patchset 3 (id:??) landed as
https://crrev.com/85313d07c90a0ff9a229646aad87ecf6cee13a38
Cr-Commit-Position: refs/heads/master@{#412422}