cc : Add OnOpacityAnimated to effect tree

cc : Add OnOpacityAnimated to effect tree

And use it to update opacity animations directly instead of
routing the updates through layers

BUG=638297
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/898b2f178e201a89384927f992735924bdc50ead
Cr-Commit-Position: refs/heads/master@{#413319}

[jaydasika, 2016-08-17 22:57:58]

Description was changed from

==========
cc : Add OnOpacityAnimated to effect tree

BUG=638297
==========

to

==========
cc : Add OnOpacityAnimated to effect tree

BUG=638297
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[jaydasika, 2016-08-18 18:17:24]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[jaydasika, 2016-08-18 18:18:00]

Description was changed from

==========
cc : Add OnOpacityAnimated to effect tree

BUG=638297
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc : Add OnOpacityAnimated to effect tree

And use it to update opacity animations directly instead of
routing the updates through layers

BUG=638297
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-08-18 18:18:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jaydasika, 2016-08-18 18:20:54]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org

[jaydasika, 2016-08-18 18:20:54]

This doesn't change calling OnOpacityAnimated for scrollbar layers, still trying
to figure out how to use effect tree version there as it happens during push
properties and I think before effect tree index is pushed. So, will do that in a
follow up.

[ajuma, 2016-08-18 18:49:26]

https://codereview.chromium.org/2253233003/diff/40001/cc/layers/render_surfac...
File cc/layers/render_surface_unittest.cc (right):

https://codereview.chromium.org/2253233003/diff/40001/cc/layers/render_surfac...
cc/layers/render_surface_unittest.cc:64:
host_impl.active_tree()->root_layer_for_testing()->effect_tree_index(),
Should this be owning_layer->effect_tree_index()?

https://codereview.chromium.org/2253233003/diff/40001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/2253233003/diff/40001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_impl.cc:3922: opacity, layer->effect_tree_index(),
tree);
Can we get the effect tree index from the id to index map to remove the
dependency on |layer| altogether? Is the problem that we don't have a way to map
from element_id to layer id? If so, I think the id-to-index map should really be
mapping ElementId to index rather than layer id to index. (But that change can
happen in a separate CL.)

[jaydasika, 2016-08-18 19:56:19]

Patchset #4 (id:60001) has been deleted

[jaydasika, 2016-08-18 19:57:52]

https://codereview.chromium.org/2253233003/diff/40001/cc/layers/render_surfac...
File cc/layers/render_surface_unittest.cc (right):

https://codereview.chromium.org/2253233003/diff/40001/cc/layers/render_surfac...
cc/layers/render_surface_unittest.cc:64:
host_impl.active_tree()->root_layer_for_testing()->effect_tree_index(),
On 2016/08/18 18:49:26, ajuma wrote:
> Should this be owning_layer->effect_tree_index()?

owning layer is the root layer here. See line 53. Not using owning_layer
directly as line 53 does a std::move.

https://codereview.chromium.org/2253233003/diff/40001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/2253233003/diff/40001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_impl.cc:3922: opacity, layer->effect_tree_index(),
tree);
On 2016/08/18 18:49:26, ajuma wrote:
> Can we get the effect tree index from the id to index map to remove the
> dependency on |layer| altogether? Is the problem that we don't have a way to
map
> from element_id to layer id? If so, I think the id-to-index map should really
be
> mapping ElementId to index rather than layer id to index. (But that change can
> happen in a separate CL.)

Acknowledged. Will do that in a separate CL.

[ajuma, 2016-08-18 20:45:36]

Thanks, lgtm

https://codereview.chromium.org/2253233003/diff/40001/cc/layers/render_surfac...
File cc/layers/render_surface_unittest.cc (right):

https://codereview.chromium.org/2253233003/diff/40001/cc/layers/render_surfac...
cc/layers/render_surface_unittest.cc:64:
host_impl.active_tree()->root_layer_for_testing()->effect_tree_index(),
On 2016/08/18 19:57:52, jaydasika wrote:
> On 2016/08/18 18:49:26, ajuma wrote:
> > Should this be owning_layer->effect_tree_index()?
> 
> owning layer is the root layer here. See line 53. Not using owning_layer
> directly as line 53 does a std::move.

Ah, I missed that!

[jaydasika, 2016-08-18 21:04:07]

jaydasika@chromium.org changed reviewers:
+ vollick@chromium.org

[jaydasika, 2016-08-18 21:04:08]

vollick : Can you review changes in platform/graphics ?

[jaydasika, 2016-08-18 21:35:53]

The CQ bit was checked by jaydasika@chromium.org

[jaydasika, 2016-08-18 21:35:57]

The CQ bit was unchecked by jaydasika@chromium.org

[Ian Vollick, 2016-08-19 17:58:39]

On 2016/08/18 21:04:08, jaydasika wrote:
> vollick : Can you review changes in platform/graphics ?

lgtm.

[jaydasika, 2016-08-19 17:59:19]

The CQ bit was checked by jaydasika@chromium.org

[commit-bot: I haz the power, 2016-08-19 18:00:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 00:19:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 00:19:21]

Exceeded global retry quota

[jaydasika, 2016-08-20 00:50:35]

The CQ bit was checked by jaydasika@chromium.org

[commit-bot: I haz the power, 2016-08-20 00:51:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 04:22:29]

Description was changed from

==========
cc : Add OnOpacityAnimated to effect tree

And use it to update opacity animations directly instead of
routing the updates through layers

BUG=638297
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc : Add OnOpacityAnimated to effect tree

And use it to update opacity animations directly instead of
routing the updates through layers

BUG=638297
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-08-20 04:22:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-20 04:23:51]

Description was changed from

==========
cc : Add OnOpacityAnimated to effect tree

And use it to update opacity animations directly instead of
routing the updates through layers

BUG=638297
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc : Add OnOpacityAnimated to effect tree

And use it to update opacity animations directly instead of
routing the updates through layers

BUG=638297
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/898b2f178e201a89384927f992735924bdc50ead
Cr-Commit-Position: refs/heads/master@{#413319}
==========

[commit-bot: I haz the power, 2016-08-20 04:23:53]

Patchset 3 (id:??) landed as
https://crrev.com/898b2f178e201a89384927f992735924bdc50ead
Cr-Commit-Position: refs/heads/master@{#413319}