cc : Add OnOpacityAnimated to effect tree

cc/layers/render_surface_unittest.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layers/append_quads_data.h"
 #include "cc/layers/layer_impl.h"
 #include "cc/layers/render_pass_sink.h"
 #include "cc/layers/render_surface_impl.h"
 #include "cc/quads/shared_quad_state.h"
 #include "cc/test/fake_impl_task_runner_provider.h"
@@ skipping 32 matching lines @@
   TestTaskGraphRunner task_graph_runner;
   FakeLayerTreeHostImpl host_impl(&task_runner_provider, &shared_bitmap_manager,
                                   &task_graph_runner);
   std::unique_ptr<LayerImpl> owning_layer =
       LayerImpl::Create(host_impl.active_tree(), 1);
   owning_layer->SetHasRenderSurface(true);
   ASSERT_TRUE(owning_layer->render_surface());
   RenderSurfaceImpl* render_surface = owning_layer->render_surface();
   gfx::Rect test_rect(3, 4, 5, 6);
   host_impl.active_tree()->ResetAllChangeTracking();
+  host_impl.active_tree()->SetRootLayerForTesting(std::move(owning_layer));
+  host_impl.active_tree()->BuildPropertyTreesForTesting();
 
   // Currently, the content_rect, clip_rect, and
   // owning_layer->layerPropertyChanged() are the only sources of change.
   EXECUTE_AND_VERIFY_SURFACE_CHANGED(render_surface->SetClipRect(test_rect));
   EXECUTE_AND_VERIFY_SURFACE_CHANGED(
       render_surface->SetContentRectForTesting(test_rect));
 
-  owning_layer->OnOpacityAnimated(0.5f);
+  host_impl.active_tree()->property_trees()->effect_tree.OnOpacityAnimated(
+      0.5f,
+      host_impl.active_tree()->root_layer_for_testing()->effect_tree_index(),

[ajuma, 2016/08/18 18:49:26]

Should this be owning_layer->effect_tree_index()?

[jaydasika, 2016/08/18 19:57:52]

owning layer is the root layer here. See line 53. Not using owning_layer
directly as line 53 does a std::move.

[ajuma, 2016/08/18 20:45:36]

Ah, I missed that!

+      host_impl.active_tree());
   EXPECT_TRUE(render_surface->SurfacePropertyChanged());
   host_impl.active_tree()->ResetAllChangeTracking();
 
   // Setting the surface properties to the same values again should not be
   // considered "change".
   EXECUTE_AND_VERIFY_SURFACE_DID_NOT_CHANGE(
       render_surface->SetClipRect(test_rect));
   EXECUTE_AND_VERIFY_SURFACE_DID_NOT_CHANGE(
       render_surface->SetContentRectForTesting(test_rect));
 
@@ skipping 118 matching lines @@
   ASSERT_EQ(1u, pass_sink.RenderPasses().size());
   RenderPass* pass = pass_sink.RenderPasses()[0].get();
 
   EXPECT_EQ(RenderPassId(2, 0), pass->id);
   EXPECT_EQ(content_rect, pass->output_rect);
   EXPECT_EQ(origin, pass->transform_to_root_target);
 }
 
 }  // namespace
 }  // namespace cc