Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8265)

Unified Diff: cc/layers/render_surface_unittest.cc

Issue 2253233003: cc : Add OnOpacityAnimated to effect tree (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layers/render_surface_unittest.cc
diff --git a/cc/layers/render_surface_unittest.cc b/cc/layers/render_surface_unittest.cc
index ef073bda2293f48140c30673cec803fbce2c7de5..c13425545aa9e8a41d6904883538f569242272dc 100644
--- a/cc/layers/render_surface_unittest.cc
+++ b/cc/layers/render_surface_unittest.cc
@@ -50,6 +50,8 @@ TEST(RenderSurfaceTest, VerifySurfaceChangesAreTrackedProperly) {
RenderSurfaceImpl* render_surface = owning_layer->render_surface();
gfx::Rect test_rect(3, 4, 5, 6);
host_impl.active_tree()->ResetAllChangeTracking();
+ host_impl.active_tree()->SetRootLayerForTesting(std::move(owning_layer));
+ host_impl.active_tree()->BuildPropertyTreesForTesting();
// Currently, the content_rect, clip_rect, and
// owning_layer->layerPropertyChanged() are the only sources of change.
@@ -57,7 +59,10 @@ TEST(RenderSurfaceTest, VerifySurfaceChangesAreTrackedProperly) {
EXECUTE_AND_VERIFY_SURFACE_CHANGED(
render_surface->SetContentRectForTesting(test_rect));
- owning_layer->OnOpacityAnimated(0.5f);
+ host_impl.active_tree()->property_trees()->effect_tree.OnOpacityAnimated(
+ 0.5f,
+ host_impl.active_tree()->root_layer_for_testing()->effect_tree_index(),
ajuma 2016/08/18 18:49:26 Should this be owning_layer->effect_tree_index()?
jaydasika 2016/08/18 19:57:52 owning layer is the root layer here. See line 53.
ajuma 2016/08/18 20:45:36 Ah, I missed that!
+ host_impl.active_tree());
EXPECT_TRUE(render_surface->SurfacePropertyChanged());
host_impl.active_tree()->ResetAllChangeTracking();

Powered by Google App Engine
This is Rietveld 408576698