Return MaybeHandle from SetProperty.

Return MaybeHandle from SetProperty.

R=ishell@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=20509

[Igor Sheludko, 2014-04-04 10:58:19]

https://codereview.chromium.org/225283005/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/225283005/diff/1/src/api.cc#newcode6984
src/api.cc:6984: EXCEPTION_BAILOUT_CHECK(isolate, Local<Value>());
This second EXCEPTION_BAILOUT_CHECK will decrement call depth for the second
time which is not good. I think you should keep the second EXCEPTION_PREAMBLE.

https://codereview.chromium.org/225283005/diff/1/src/isolate.h
File src/isolate.h (right):

https://codereview.chromium.org/225283005/diff/1/src/isolate.h#newcode193
src/isolate.h:193: isolate, call, MaybeHandle<T>())
Now it fits one line.

https://codereview.chromium.org/225283005/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/225283005/diff/1/src/runtime.cc#newcode216
src/runtime.cc:216: static MaybeHandle<Object> CreateLiteralBoilerplate(
I think you should add MUST_USE_RESULT here and for every static MaybeHandle<>
function below.

https://codereview.chromium.org/225283005/diff/1/src/runtime.h
File src/runtime.h (right):

https://codereview.chromium.org/225283005/diff/1/src/runtime.h#newcode901
src/runtime.h:901: static MaybeHandle<Object> CreateArrayLiteralBoilerplate(
MUST_USE_RESULT

https://codereview.chromium.org/225283005/diff/1/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):

https://codereview.chromium.org/225283005/diff/1/test/cctest/test-heap.cc#new...
test/cctest/test-heap.cc:288: JSReceiver::SetProperty(global, name, function,
NONE, SLOPPY).Assert();
Shouldn't we use .Check() here and in all other tests?

[Yang, 2014-04-04 11:17:41]

https://codereview.chromium.org/225283005/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/225283005/diff/1/src/api.cc#newcode6984
src/api.cc:6984: EXCEPTION_BAILOUT_CHECK(isolate, Local<Value>());
On 2014/04/04 10:58:19, Igor Sheludko wrote:
> This second EXCEPTION_BAILOUT_CHECK will decrement call depth for the second
> time which is not good. I think you should keep the second EXCEPTION_PREAMBLE.

Good point. I will remove the new EXCEPTION_BAILOUT_CHECK. Adding another
preamble won't work since it defines a bool.

https://codereview.chromium.org/225283005/diff/1/src/isolate.h
File src/isolate.h (right):

https://codereview.chromium.org/225283005/diff/1/src/isolate.h#newcode193
src/isolate.h:193: isolate, call, MaybeHandle<T>())
On 2014/04/04 10:58:19, Igor Sheludko wrote:
> Now it fits one line.

Done.

https://codereview.chromium.org/225283005/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/225283005/diff/1/src/runtime.cc#newcode216
src/runtime.cc:216: static MaybeHandle<Object> CreateLiteralBoilerplate(
On 2014/04/04 10:58:19, Igor Sheludko wrote:
> I think you should add MUST_USE_RESULT here and for every static MaybeHandle<>
> function below.

Done.

https://codereview.chromium.org/225283005/diff/1/src/runtime.h
File src/runtime.h (right):

https://codereview.chromium.org/225283005/diff/1/src/runtime.h#newcode901
src/runtime.h:901: static MaybeHandle<Object> CreateArrayLiteralBoilerplate(
On 2014/04/04 10:58:19, Igor Sheludko wrote:
> MUST_USE_RESULT

Done.

https://codereview.chromium.org/225283005/diff/1/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):

https://codereview.chromium.org/225283005/diff/1/test/cctest/test-heap.cc#new...
test/cctest/test-heap.cc:288: JSReceiver::SetProperty(global, name, function,
NONE, SLOPPY).Assert();
On 2014/04/04 10:58:19, Igor Sheludko wrote:
> Shouldn't we use .Check() here and in all other tests?

Done.

[Igor Sheludko, 2014-04-04 11:34:35]

lgtm with a nit: please use .Check() in other cctest files you modified.

[Yang, 2014-04-04 12:06:37]

Committed patchset #2 manually as r20509 (presubmit successful).