Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: test/cctest/test-debug.cc

Issue 225283005: Return MaybeHandle from SetProperty. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/cctest/test-compiler.cc ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 debug->debug_context()->set_security_token( 107 debug->debug_context()->set_security_token(
108 v8::Utils::OpenHandle(*context_)->security_token()); 108 v8::Utils::OpenHandle(*context_)->security_token());
109 109
110 Handle<JSGlobalProxy> global(Handle<JSGlobalProxy>::cast( 110 Handle<JSGlobalProxy> global(Handle<JSGlobalProxy>::cast(
111 v8::Utils::OpenHandle(*context_->Global()))); 111 v8::Utils::OpenHandle(*context_->Global())));
112 Handle<v8::internal::String> debug_string = 112 Handle<v8::internal::String> debug_string =
113 factory->InternalizeOneByteString(STATIC_ASCII_VECTOR("debug")); 113 factory->InternalizeOneByteString(STATIC_ASCII_VECTOR("debug"));
114 v8::internal::Runtime::SetObjectProperty(isolate, global, debug_string, 114 v8::internal::Runtime::SetObjectProperty(isolate, global, debug_string,
115 Handle<Object>(debug->debug_context()->global_proxy(), isolate), 115 Handle<Object>(debug->debug_context()->global_proxy(), isolate),
116 DONT_ENUM, 116 DONT_ENUM,
117 ::v8::internal::SLOPPY); 117 ::v8::internal::SLOPPY).Assert();
118 } 118 }
119 119
120 private: 120 private:
121 v8::HandleScope scope_; 121 v8::HandleScope scope_;
122 v8::Local<v8::Context> context_; 122 v8::Local<v8::Context> context_;
123 }; 123 };
124 124
125 125
126 // --- H e l p e r F u n c t i o n s 126 // --- H e l p e r F u n c t i o n s
127 127
(...skipping 7529 matching lines...) Expand 10 before | Expand all | Expand 10 after
7657 CHECK(result->IsString()); 7657 CHECK(result->IsString());
7658 v8::String::Utf8Value utf8(result); 7658 v8::String::Utf8Value utf8(result);
7659 CHECK_EQ("bar", *utf8); 7659 CHECK_EQ("bar", *utf8);
7660 7660
7661 v8::Debug::SetDebugEventListener2(NULL); 7661 v8::Debug::SetDebugEventListener2(NULL);
7662 CheckDebuggerUnloaded(); 7662 CheckDebuggerUnloaded();
7663 } 7663 }
7664 7664
7665 7665
7666 #endif // ENABLE_DEBUGGER_SUPPORT 7666 #endif // ENABLE_DEBUGGER_SUPPORT
OLDNEW
« no previous file with comments | « test/cctest/test-compiler.cc ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698