Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: src/liveedit.cc

Issue 225283005: Return MaybeHandle from SetProperty. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/json-parser.h ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 938 matching lines...) Expand 10 before | Expand all | Expand 10 after
949 STATIC_ASCII_VECTOR("startPosition")); 949 STATIC_ASCII_VECTOR("startPosition"));
950 Handle<String> end_pos_key = factory->InternalizeOneByteString( 950 Handle<String> end_pos_key = factory->InternalizeOneByteString(
951 STATIC_ASCII_VECTOR("endPosition")); 951 STATIC_ASCII_VECTOR("endPosition"));
952 Handle<String> script_obj_key = factory->InternalizeOneByteString( 952 Handle<String> script_obj_key = factory->InternalizeOneByteString(
953 STATIC_ASCII_VECTOR("scriptObject")); 953 STATIC_ASCII_VECTOR("scriptObject"));
954 Handle<Smi> start_pos( 954 Handle<Smi> start_pos(
955 Smi::FromInt(message_location.start_pos()), isolate); 955 Smi::FromInt(message_location.start_pos()), isolate);
956 Handle<Smi> end_pos(Smi::FromInt(message_location.end_pos()), isolate); 956 Handle<Smi> end_pos(Smi::FromInt(message_location.end_pos()), isolate);
957 Handle<JSValue> script_obj = GetScriptWrapper(message_location.script()); 957 Handle<JSValue> script_obj = GetScriptWrapper(message_location.script());
958 JSReceiver::SetProperty( 958 JSReceiver::SetProperty(
959 rethrow_exception, start_pos_key, start_pos, NONE, SLOPPY); 959 rethrow_exception, start_pos_key, start_pos, NONE, SLOPPY).Assert();
960 JSReceiver::SetProperty( 960 JSReceiver::SetProperty(
961 rethrow_exception, end_pos_key, end_pos, NONE, SLOPPY); 961 rethrow_exception, end_pos_key, end_pos, NONE, SLOPPY).Assert();
962 JSReceiver::SetProperty( 962 JSReceiver::SetProperty(
963 rethrow_exception, script_obj_key, script_obj, NONE, SLOPPY); 963 rethrow_exception, script_obj_key, script_obj, NONE, SLOPPY).Assert();
964 } 964 }
965 } 965 }
966 966
967 // A logical 'finally' section. 967 // A logical 'finally' section.
968 isolate->set_active_function_info_listener(NULL); 968 isolate->set_active_function_info_listener(NULL);
969 script->set_source(*original_source); 969 script->set_source(*original_source);
970 970
971 if (rethrow_exception.is_null()) { 971 if (rethrow_exception.is_null()) {
972 return *(listener.GetResult()); 972 return *(listener.GetResult());
973 } else { 973 } else {
(...skipping 1153 matching lines...) Expand 10 before | Expand all | Expand 10 after
2127 2127
2128 bool LiveEditFunctionTracker::IsActive(Isolate* isolate) { 2128 bool LiveEditFunctionTracker::IsActive(Isolate* isolate) {
2129 return false; 2129 return false;
2130 } 2130 }
2131 2131
2132 #endif // ENABLE_DEBUGGER_SUPPORT 2132 #endif // ENABLE_DEBUGGER_SUPPORT
2133 2133
2134 2134
2135 2135
2136 } } // namespace v8::internal 2136 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/json-parser.h ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698