Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: tools/gn/json_project_writer.cc

Issue 2252293003: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/functions_unittest.cc ('k') | tools/gn/parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/json_project_writer.cc
diff --git a/tools/gn/json_project_writer.cc b/tools/gn/json_project_writer.cc
index dc375a64d940d6c26fc8af074cfe59a8ccad4139..67c21ee2d7f68eebeb79abcf6945373d1fd80eed 100644
--- a/tools/gn/json_project_writer.cc
+++ b/tools/gn/json_project_writer.cc
@@ -86,7 +86,7 @@ std::string RenderJSON(const BuildSettings* build_settings,
std::vector<const Target*>& all_targets) {
Label default_toolchain_label;
- auto targets = base::WrapUnique(new base::DictionaryValue());
+ auto targets = base::MakeUnique<base::DictionaryValue>();
for (const auto* target : all_targets) {
if (default_toolchain_label.is_null())
default_toolchain_label = target->settings()->default_toolchain_label();
@@ -104,13 +104,13 @@ std::string RenderJSON(const BuildSettings* build_settings,
std::move(description));
}
- auto settings = base::WrapUnique(new base::DictionaryValue());
+ auto settings = base::MakeUnique<base::DictionaryValue>();
settings->SetString("root_path", build_settings->root_path_utf8());
settings->SetString("build_dir", build_settings->build_dir().value());
settings->SetString("default_toolchain",
default_toolchain_label.GetUserVisibleName(false));
- auto output = base::WrapUnique(new base::DictionaryValue());
+ auto output = base::MakeUnique<base::DictionaryValue>();
output->Set("targets", std::move(targets));
output->Set("build_settings", std::move(settings));
« no previous file with comments | « tools/gn/functions_unittest.cc ('k') | tools/gn/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698