tools/gn/functions_unittest.cc - Issue 2252293003: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/functions_unittest.cc

Issue 2252293003: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/functions_unittest.cc

diff --git a/tools/gn/functions_unittest.cc b/tools/gn/functions_unittest.cc

index c6681bf5909b78362e2c0a80c77abfbe5ef956e6..7156747471225952ae48d78b3b5f4ca8e509449b 100644

--- a/tools/gn/functions_unittest.cc

+++ b/tools/gn/functions_unittest.cc

@@ -48,8 +48,7 @@ TEST(Functions, Defined) {

// "defined(def.foo)" to see if foo is defined on the def scope.

std::unique_ptr<AccessorNode> undef_accessor(new AccessorNode);

undef_accessor->set_base(defined_token);

- undef_accessor->set_member(

- base::WrapUnique(new IdentifierNode(undefined_token)));

+ undef_accessor->set_member(base::MakeUnique<IdentifierNode>(undefined_token));

ListNode args_list_accessor_defined;

args_list_accessor_defined.append_item(std::move(undef_accessor));

result = functions::RunDefined(setup.scope(), &function_call,

« no previous file with comments | « tools/gn/desc_builder.cc ('k') | tools/gn/json_project_writer.cc » ('j') | no next file with comments »