Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: tools/gn/parser.cc

Issue 2252293003: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/json_project_writer.cc ('k') | tools/gn/xcode_object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/parser.cc
diff --git a/tools/gn/parser.cc b/tools/gn/parser.cc
index 76d4580fd6e931246d6034d1f873a5056d672961..5fe9506d4528bd9cbd94fefd69b9a591d634788d 100644
--- a/tools/gn/parser.cc
+++ b/tools/gn/parser.cc
@@ -462,7 +462,7 @@ std::unique_ptr<ParseNode> Parser::Block(const Token& token) {
}
std::unique_ptr<ParseNode> Parser::Literal(const Token& token) {
- return base::WrapUnique(new LiteralNode(token));
+ return base::MakeUnique<LiteralNode>(token);
}
std::unique_ptr<ParseNode> Parser::Name(const Token& token) {
@@ -529,7 +529,7 @@ std::unique_ptr<ParseNode> Parser::IdentifierOrCall(
const Token& token) {
std::unique_ptr<ListNode> list(new ListNode);
list->set_begin_token(token);
- list->set_end(base::WrapUnique(new EndNode(token)));
+ list->set_end(base::MakeUnique<EndNode>(token));
std::unique_ptr<BlockNode> block;
bool has_arg = false;
if (LookAhead(Token::LEFT_PAREN)) {
@@ -669,7 +669,7 @@ std::unique_ptr<ListNode> Parser::ParseList(const Token& start_token,
*err_ = Err(cur_token(), "Trailing comma");
return std::unique_ptr<ListNode>();
}
- list->set_end(base::WrapUnique(new EndNode(cur_token())));
+ list->set_end(base::MakeUnique<EndNode>(cur_token()));
return list;
}
@@ -728,7 +728,7 @@ std::unique_ptr<BlockNode> Parser::ParseBlock(
for (;;) {
if (LookAhead(Token::RIGHT_BRACE)) {
- block->set_end(base::WrapUnique(new EndNode(Consume())));
+ block->set_end(base::MakeUnique<EndNode>(Consume()));
break;
}
« no previous file with comments | « tools/gn/json_project_writer.cc ('k') | tools/gn/xcode_object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698