[wasm] asm.js - Check stdlib.NaN is valid, prepare for the rest.

[wasm] asm.js - Check stdlib.NaN is valid, prepare for the rest.

Record which asm.js stdlib members are used and add a check that NaN is actually correctly set. Other stdlib members to be added in a later change.

Also add a stdlib argument to Wasm.instantiateModuleFromAsm, in preparation for that function to be replaced by normal asm.js instantiation.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org,titzer@chromium.org

Committed: https://crrev.com/561bfcb70d5ed2757ba9477d8fabc95b1c5d20f0
Cr-Commit-Position: refs/heads/master@{#38760}

[bradnelson, 2016-08-15 19:35:56]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 19:36:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 19:58:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 19:58:16]

Dry run: This issue passed the CQ dry run.

[bradnelson, 2016-08-19 07:41:29]

Description was changed from

==========
[wasm] asm.js Check stdlib functions are valid.

This also adds a stdlib argument to Wasm.instantiateModuleFromAsm.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org
==========

to

==========
[wasm] asm.js - Refactor to prepare to check stdlib members are valid.

Records which asm.js stdlib members are used and add a check that NaN is
actually correctly set.
It also adds a stdlib argument to Wasm.instantiateModuleFromAsm, in preparation
for that function to be replaced by normal asm.js instantiation.
Other stdlib functions will be implemented in a later CL.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org
==========

[bradnelson, 2016-08-19 07:56:07]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 07:56:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bradnelson, 2016-08-19 07:57:49]

Description was changed from

==========
[wasm] asm.js - Refactor to prepare to check stdlib members are valid.

Records which asm.js stdlib members are used and add a check that NaN is
actually correctly set.
It also adds a stdlib argument to Wasm.instantiateModuleFromAsm, in preparation
for that function to be replaced by normal asm.js instantiation.
Other stdlib functions will be implemented in a later CL.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org
==========

to

==========
[wasm] asm.js - Check stdlib.NaN is valid, prepare for the rest.

Record which asm.js stdlib members are used and add a check that NaN is actually
correctly set. Other stdlib members to be added in a later change.

Also add a stdlib argument to Wasm.instantiateModuleFromAsm, in preparation for
that function to be replaced by normal asm.js instantiation.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org
==========

[bradnelson, 2016-08-19 08:00:07]

Description was changed from

==========
[wasm] asm.js - Check stdlib.NaN is valid, prepare for the rest.

Record which asm.js stdlib members are used and add a check that NaN is actually
correctly set. Other stdlib members to be added in a later change.

Also add a stdlib argument to Wasm.instantiateModuleFromAsm, in preparation for
that function to be replaced by normal asm.js instantiation.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org
==========

to

==========
[wasm] asm.js - Check stdlib.NaN is valid, prepare for the rest.

Record which asm.js stdlib members are used and add a check that NaN is actually
correctly set. Other stdlib members to be added in a later change.

Also add a stdlib argument to Wasm.instantiateModuleFromAsm, in preparation for
that function to be replaced by normal asm.js instantiation.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org,titzer@chromium.org
==========

[bradnelson, 2016-08-19 08:00:07]

bradnelson@chromium.org changed reviewers:
+ titzer@chromium.org

[commit-bot: I haz the power, 2016-08-19 08:18:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 08:18:34]

Dry run: This issue passed the CQ dry run.

[titzer, 2016-08-19 10:00:29]

lgtm

https://codereview.chromium.org/2251433002/diff/20001/src/asmjs/asm-js.cc
File src/asmjs/asm-js.cc (right):

https://codereview.chromium.org/2251433002/diff/20001/src/asmjs/asm-js.cc#new...
src/asmjs/asm-js.cc:112: }
Do you want to return true here and then false for others (default case)?

https://codereview.chromium.org/2251433002/diff/20001/src/runtime/runtime-com...
File src/runtime/runtime-compiler.cc (right):

https://codereview.chromium.org/2251433002/diff/20001/src/runtime/runtime-com...
src/runtime/runtime-compiler.cc:98: args.at<JSObject>(1))) {
Does that need to be args.at<JSReceiver>?

[bradn, 2016-08-19 17:29:08]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2016-08-19 17:29:08]

https://codereview.chromium.org/2251433002/diff/20001/src/asmjs/asm-js.cc
File src/asmjs/asm-js.cc (right):

https://codereview.chromium.org/2251433002/diff/20001/src/asmjs/asm-js.cc#new...
src/asmjs/asm-js.cc:112: }
On 2016/08/19 10:00:28, titzer wrote:
> Do you want to return true here and then false for others (default case)?

Actually not, because this needs to loop to check each.

Separated out per member check into a separate method to make this more clear.

https://codereview.chromium.org/2251433002/diff/20001/src/runtime/runtime-com...
File src/runtime/runtime-compiler.cc (right):

https://codereview.chromium.org/2251433002/diff/20001/src/runtime/runtime-com...
src/runtime/runtime-compiler.cc:98: args.at<JSObject>(1))) {
On 2016/08/19 10:00:28, titzer wrote:
> Does that need to be args.at<JSReceiver>?

Done.

[bradn, 2016-08-19 17:29:12]

The CQ bit was checked by bradnelson@google.com

[bradn, 2016-08-19 17:29:13]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2251433002/#ps40001
(title: "fix")

[commit-bot: I haz the power, 2016-08-19 17:29:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 17:47:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 17:47:04]

Try jobs failed on following builders:
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/2...)

[bradn, 2016-08-19 17:48:08]

The CQ bit was checked by bradnelson@google.com

[bradn, 2016-08-19 17:48:08]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2251433002/#ps60001
(title: "fix")

[commit-bot: I haz the power, 2016-08-19 17:48:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 18:25:46]

Description was changed from

==========
[wasm] asm.js - Check stdlib.NaN is valid, prepare for the rest.

Record which asm.js stdlib members are used and add a check that NaN is actually
correctly set. Other stdlib members to be added in a later change.

Also add a stdlib argument to Wasm.instantiateModuleFromAsm, in preparation for
that function to be replaced by normal asm.js instantiation.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org,titzer@chromium.org
==========

to

==========
[wasm] asm.js - Check stdlib.NaN is valid, prepare for the rest.

Record which asm.js stdlib members are used and add a check that NaN is actually
correctly set. Other stdlib members to be added in a later change.

Also add a stdlib argument to Wasm.instantiateModuleFromAsm, in preparation for
that function to be replaced by normal asm.js instantiation.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org,titzer@chromium.org
==========

[commit-bot: I haz the power, 2016-08-19 18:25:47]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-19 18:26:35]

Description was changed from

==========
[wasm] asm.js - Check stdlib.NaN is valid, prepare for the rest.

Record which asm.js stdlib members are used and add a check that NaN is actually
correctly set. Other stdlib members to be added in a later change.

Also add a stdlib argument to Wasm.instantiateModuleFromAsm, in preparation for
that function to be replaced by normal asm.js instantiation.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org,titzer@chromium.org
==========

to

==========
[wasm] asm.js - Check stdlib.NaN is valid, prepare for the rest.

Record which asm.js stdlib members are used and add a check that NaN is actually
correctly set. Other stdlib members to be added in a later change.

Also add a stdlib argument to Wasm.instantiateModuleFromAsm, in preparation for
that function to be replaced by normal asm.js instantiation.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org,titzer@chromium.org

Committed: https://crrev.com/561bfcb70d5ed2757ba9477d8fabc95b1c5d20f0
Cr-Commit-Position: refs/heads/master@{#38760}
==========

[commit-bot: I haz the power, 2016-08-19 18:26:36]

Patchset 4 (id:??) landed as
https://crrev.com/561bfcb70d5ed2757ba9477d8fabc95b1c5d20f0
Cr-Commit-Position: refs/heads/master@{#38760}